Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis: 4.0.11 -> 5.0.0 #48783

Merged
merged 1 commit into from Oct 23, 2018
Merged

redis: 4.0.11 -> 5.0.0 #48783

merged 1 commit into from Oct 23, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 21, 2018

Motivation for this change

https://raw.githubusercontent.com/antirez/redis/5.0/00-RELEASENOTES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Oct 22, 2018

@GrahamcOfBorg build redis

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: redis

Partial log (click to expand)

    INSTALL install
    INSTALL install
    INSTALL install
    INSTALL install
make[1]: Leaving directory '/private/tmp/nix-build-redis-5.0.0.drv-0/redis-5.0.0/src'
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mijn2b4p5rd6cm2qrv366djxv8q56965-redis-5.0.0/bin
patching script interpreter paths in /nix/store/mijn2b4p5rd6cm2qrv366djxv8q56965-redis-5.0.0
/nix/store/mijn2b4p5rd6cm2qrv366djxv8q56965-redis-5.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: redis

Partial log (click to expand)

shrinking /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0/bin/redis-check-aof
shrinking /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0/bin/redis-check-rdb
shrinking /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0/bin/redis-cli
shrinking /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0/bin/redis-benchmark
shrinking /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0/bin/redis-server
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0/bin
patching script interpreter paths in /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0
checking for references to /build in /nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0...
/nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0

@srhb
Copy link
Contributor

srhb commented Oct 22, 2018

@GrahamcOfBorg build redis

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: redis

Partial log (click to expand)

/nix/store/qa504by56nhb7bim2fgz0sibagfijn3i-redis-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: redis

Partial log (click to expand)

/nix/store/mijn2b4p5rd6cm2qrv366djxv8q56965-redis-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: redis

Partial log (click to expand)

shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-server
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-check-aof
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-check-rdb
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-benchmark
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-cli
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin
patching script interpreter paths in /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0
checking for references to /build in /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0...
/nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: redis

Partial log (click to expand)

shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-check-rdb
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-cli
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-benchmark
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-server
shrinking /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin/redis-check-aof
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0/bin
patching script interpreter paths in /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0
checking for references to /build in /nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0...
/nix/store/38k39vi6n0lcdvzprkfbay0bfrrsva6k-redis-5.0.0

srhb
srhb reviewed Oct 22, 2018
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any major changes we should document in the 19.03 release notes?

@marsam
Copy link
Contributor Author

marsam commented Oct 22, 2018

@srhb afaik redis doesn't use semantic versioning, so this upgrade doesn't have major breaking changes. I've found the following https://aws.amazon.com/redis/Whats_New_Redis5/#Upgrade_considerations but I'm not sure if we should add it to the release notes

@srhb
Copy link
Contributor

srhb commented Oct 23, 2018

@marsam Thank you for that. If I read this correctly, it's entirely forwards-compatible, so no release notes should be necessary.

@srhb
Copy link
Contributor

srhb commented Oct 23, 2018

Tested with every test that incidentally uses redis in nixos/tests. Looks good. Should this be backported to 18.09?

@srhb srhb merged commit 1d8c5e7 into NixOS:master Oct 23, 2018
@srhb
Copy link
Contributor

srhb commented Oct 23, 2018

cc @berdario

@marsam marsam deleted the feature/update-redis branch October 23, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @srhb @GrahamcOfBorg