MediaService: Add Poweramp handling for media controls #59
Conversation
Myself5
force-pushed
the
media_controls_poweramp
branch
from
f99c0ac
to
ae337e5
Compare
* Imported from https://github.com/maxmpz/powerampapi with the head of maxmpz/powerampapi/e743666ca1b677b1edd095e327dc3e8f5ea322dc * Remove all examples and uneeded code as we only require the Player handling * Keep PowerampAPI and PowerampAPIHelper in tact for easier updates
Myself5
force-pushed
the
media_controls_poweramp
branch
from
ae337e5
to
bc91774
Compare
There was a problem hiding this comment.
Err, it's killing me that we have to introduce this kind of workaround for apps that don't know how to behave properly. However, even if I don't like the solution, I think it's necessary to solve that problem.
I just had a couple of questions to ask but after you answer them I'm willing to merge this.
| @@ -24,6 +24,8 @@ android { | |||
| main.res.srcDirs += 'src/main/lib/android-ripple-background/library/src/main/res/' | |||
| main.java.srcDirs += 'src/main/lib/material-intro-screen/material-intro-screen/src/main/java/' | |||
| main.res.srcDirs += 'src/main/lib/material-intro-screen/material-intro-screen/src/main/res/' | |||
| main.java.srcDirs += 'src/main/lib/powerampapi/poweramp_api_lib/src/' | |||
There was a problem hiding this comment.
Is there really no other way to import that lib ? (maybe from a maven repository or something, I don't know)
I would rather only use that kind of import as a last resort. It's always a pain to maintain
There was a problem hiding this comment.
I wasn't seeing a maven/gradle option right away so I just went with the way you used before and called it a day. Will do some more research if it's possible via dependencies.
There was a problem hiding this comment.
So it appears that Poweramp has no grade or maven plugins published, so I guess this is the way to go for now. As the API is only used for the basic media controls and we don't use the advanced ones (like media info or album covers) I don't worry too much about it being outdated.
|
I agree that this really shouldn't be necessary as Poweramp should provide support for the generic API but I guess for now this is what we need to deal with. I'll take care of the notes tomorrow. |
* To allow simultaneous usage we store the current MediaController in a Preference and send commands based on that.
Myself5
force-pushed
the
media_controls_poweramp
branch
from
bc91774
to
172396f
Compare
|
Thanks again @Myself5 ! :) |
I'll rebase this PR on top of master after #58 has been merged