Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin sandbox #48770

Closed
wants to merge 2 commits into from
Closed

Darwin sandbox #48770

wants to merge 2 commits into from

Conversation

hisandeepsingh
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@edolstra
xnu: Depend on python
7848422 
Before, it used /usr/bin/python, which breaks when sandboxing is enabled.
@edolstra
stdenvDarwin: Remove need for sandboxProfile magic
961e7ef 
The required sandbox rules are now builtin in Nix
(NixOS/nix@c96e8cd).

NixOS/nix#759
@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: python 6.topic: stdenv Standard environment 2.status: merge conflict labels Oct 21, 2018
@xeji
Copy link
Contributor

xeji commented Oct 21, 2018

Please explain what you are trying to achieve here. The darwin-sandbox branch that you want to merge is 1.5 years old and probably dead. Merging it now doesn't make sense to me.

@xeji
Copy link
Contributor

xeji commented Oct 22, 2018

Closing as invalid.

@xeji xeji closed this Oct 22, 2018
@FRidh FRidh mentioned this pull request Oct 25, 2018
Closed
9 tasks
@Artturin Artturin deleted the darwin-sandbox branch April 7, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: invalid 2.status: merge conflict 6.topic: darwin Running or building packages on Darwin 6.topic: python 6.topic: stdenv Standard environment 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hisandeepsingh @xeji @GrahamcOfBorg @Janik-Haag @edolstra