Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corosync: update RDMA support to rdma-core #48797

Merged
merged 1 commit into from Oct 21, 2018
Merged

corosync: update RDMA support to rdma-core #48797

merged 1 commit into from Oct 21, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

The packages librdmacm and libibverbs are deprecated and are replaced by rdma-core.

see #34314

Things done

Replaced librdmacm and libibverbs with rdma-core

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: corosync

Partial log (click to expand)

/nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/ld: cannot find -lrdmacm
/nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/ld: cannot find -libverbs
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:447: libtotem_pg.la] Error 1
make[2]: Leaving directory '/build/corosync-2.4.3/exec'
make[1]: *** [Makefile:458: all-recursive] Error 1
make[1]: Leaving directory '/build/corosync-2.4.3'
make: *** [Makefile:365: all] Error 2
builder for '/nix/store/684xm1ynakav5ijwyb3bpwp34c0k8mj8-corosync-2.4.3.drv' failed with exit code 2
error: build of '/nix/store/684xm1ynakav5ijwyb3bpwp34c0k8mj8-corosync-2.4.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: corosync

Partial log (click to expand)

/nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/ld: cannot find -lrdmacm
/nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/ld: cannot find -libverbs
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:447: libtotem_pg.la] Error 1
make[2]: Leaving directory '/build/corosync-2.4.3/exec'
make[1]: *** [Makefile:458: all-recursive] Error 1
make[1]: Leaving directory '/build/corosync-2.4.3'
make: *** [Makefile:365: all] Error 2
builder for '/nix/store/75r95fpqrzgx0hqmdv80d7z5yg0m512i-corosync-2.4.3.drv' failed with exit code 2
error: build of '/nix/store/75r95fpqrzgx0hqmdv80d7z5yg0m512i-corosync-2.4.3.drv' failed

@markuskowa
corosync: update RDMA support to rdma-core
f7dbc72 
The packages librdmacm and libibverbs are deprecated
and are replaced by rdma-core.

see NixOS#34314
@Mic92
Copy link
Member

Mic92 commented Oct 21, 2018

@GrahamcOfBorg build corosync

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: corosync

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: corosync

Partial log (click to expand)

shrinking /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/sbin/corosync-cpgtool
shrinking /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/sbin/corosync-keygen
gzipping man pages under /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/lib  /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/bin  /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/sbin
patching script interpreter paths in /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3
/nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/bin/.corosync-blackbox-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3...
moving /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/sbin/* to /nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3/bin
/nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: corosync

Partial log (click to expand)

shrinking /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/lib/libcpg.so.4.1.0
shrinking /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/lib/libcorosync_common.so.4.0.0
gzipping man pages under /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/lib  /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/bin  /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/sbin
patching script interpreter paths in /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3
/nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/bin/.corosync-blackbox-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3...
moving /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/sbin/* to /nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3/bin
/nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: corosync

Partial log (click to expand)

/nix/store/rk423x4c2bl6qa76s7qwwnq6i14b082j-corosync-2.4.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: corosync

Partial log (click to expand)

/nix/store/5jvl9pzabw131kzzq0k7bq6jls6wj5c6-corosync-2.4.3

@Mic92 Mic92 merged commit aab3b1b into NixOS:master Oct 21, 2018
@markuskowa markuskowa deleted the fix-corosync-rdma branch October 21, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @GrahamcOfBorg @Mic92