Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/munge: do not create unnecessary log dir #48791

Merged
merged 1 commit into from Oct 21, 2018
Merged

nixos/munge: do not create unnecessary log dir #48791

merged 1 commit into from Oct 21, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

The munge daemon uses the syslog facilities. /var/log/munge is thus not used.

Things done

Remove creation of /var/log/munge from munge's systemd startup procedure.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    nixos/tests/slurm.nix succeeds
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@markuskowa
nixos/munge: do not create unnecessary log dir
e3a8601 
/var/log/munge is not used. All log messages go to syslog
@markuskowa
Copy link
Member Author

@GrahamcOfBorg test slurm

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.slurm

Partial log (click to expand)

test script finished in 36.02s
cleaning up
killing node3 (pid 597)
killing submit (pid 609)
killing control (pid 621)
killing node2 (pid 633)
killing node1 (pid 645)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/1fr5ziln51nm9v796kjms6jlv4g9bvcb-vm-test-run-slurm

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.slurm

Partial log (click to expand)

test script finished in 321.82s
cleaning up
killing node1 (pid 631)
killing control (pid 643)
killing node3 (pid 657)
killing node2 (pid 670)
killing submit (pid 683)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/rki8bfq7cp40x8fxck8l25iskhkj2rkq-vm-test-run-slurm

@Mic92 Mic92 merged commit 0a5b4fd into NixOS:master Oct 21, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 21, 2018

I suppose this should be also backported?

@markuskowa
Copy link
Member Author

It is just a clean up. A backport would be safe.

@markuskowa markuskowa deleted the fix-munge branch October 21, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @GrahamcOfBorg @Mic92