Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: remove defunct infiniband support #48794

Merged
merged 1 commit into from Oct 23, 2018
Merged

samba: remove defunct infiniband support #48794

merged 1 commit into from Oct 23, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Even if the enableInfiniband option is set to true it is ignored by the configure script and no depencies to libibverbs.so or librdmacm.so are contained in the output. Google does not yield much with respect to building samba with IB support.

I did try to get it working but both variants did not result in the configure script mention the attempt to check or build with IB support:
https://gist.github.com/markuskowa/76ef1e00df809e8aa1c3606d490d05ea

Proposing to remove the defunct IB support in favor of #34314

CC @wkennington

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@markuskowa
samba: remove defunct infiniband support
8d7870d 
Even if infiniband support is enabled the option
is ignored by the configure script and no depencies
to libibverbs.so or librdmacm.so is contained in
the output.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: samba

Partial log (click to expand)

  /nix/store/wr8j4xkjgzwfxyzh02dxrvxw4318cp5r-libbsd-0.9.1
copying path '/nix/store/fynyc7sx55sv76n61ddkkp8xb59lbwxc-libaio-0.3.110' from 'https://cache.nixos.org'...
copying path '/nix/store/vc9fv2d5jb5rlpwm65l0pv277h2ink6w-libarchive-3.3.2-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/wr8j4xkjgzwfxyzh02dxrvxw4318cp5r-libbsd-0.9.1' from 'https://cache.nixos.org'...
copying path '/nix/store/4v5nkv8hkilimfxvmwkfl0mlry3qqzk9-popt-1.16' from 'https://cache.nixos.org'...
copying path '/nix/store/mg2dddnynaybaslahx25lfxq0gk44rdf-libedit-20180525-3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/sqr8x2i5k6fhkhy2dhn15zyvh54iich2-talloc-2.1.14' from 'https://cache.nixos.org'...
copying path '/nix/store/s3c27slqff746rcrca5wfy08mf2lasvv-krb5-1.15.2' from 'https://cache.nixos.org'...
copying path '/nix/store/mwdnrgf349im0mg6rns2vj4bvkhkk5mr-samba-4.7.9' from 'https://cache.nixos.org'...
/nix/store/mwdnrgf349im0mg6rns2vj4bvkhkk5mr-samba-4.7.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: samba

Partial log (click to expand)

these paths will be fetched (8.54 MiB download, 53.17 MiB unpacked):
  /nix/store/fx54acnj9wy1qixblmq11x476a7fl8qg-samba-4.7.9
copying path '/nix/store/fx54acnj9wy1qixblmq11x476a7fl8qg-samba-4.7.9' from 'https://cache.nixos.org'...
/nix/store/fx54acnj9wy1qixblmq11x476a7fl8qg-samba-4.7.9

@joachifm joachifm merged commit 48fd1fb into NixOS:master Oct 23, 2018
@markuskowa markuskowa deleted the fix-samba-ib branch October 23, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@jokogr jokogr jokogr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@markuskowa @GrahamcOfBorg @Mic92 @jokogr @joachifm