Fix toolbar background colors for dark themes #2541
Merged
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
GUI
HebaruSan
force-pushed
the
fix/toolstrip-background
branch
from
d4c24af to
084e127
Compare
|
Looks good. Could it be possible to also fix the checkboxes? |
|
The Mono code for this is extremely obfuscated, but as far as I can tell so far, no, the visual style of those checkboxes is inaccessible to modification by applications. The core drawing code gets the backcolor from a reference to a full checkbox control, which doesn't exist for the grid, so a wrapper layer around that creates a temporary checkbox control from scratch using defaults that we can't change. (It's kind of impressive how little is accomplished here with so much code. At least 8 Mono source files are involved in providing this degree of non-flexibility.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CKAN's toolbars are hideous with a dark theme:
Cause
See mono/mono#11287; Mono is trying to use
SystemColors.ButtonFacefor the left edge of a toolstrip, fading to a hard coded light color with a linear gradient. But Mono doesn't loadButtonFacefrom the system settings, instead leaving it with a compile time default.Upstream fix
mono/mono#11287 is trying to fix this in Mono by switching from
ButtonFacetoSystemColors.Control, which is set by Mono's theme loader. However, there are some downsides:Changes
Luckily this part of Mono is 90% customization / overrides / defaults / etc., so there are plenty of hooks here for us to make it work however we want. When Mono wants to draw a control, it first checks whether that control has a
.Rendererproperty, and if it does, it delegates the drawing to that object. Now we populate that property with our own renderer that just draws the background color normally. This looks better than the renderer built into Mono, even after the other fix, and will work for all users regardless of their version of Mono.Fixes #2525.