Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37: 3.7.0 -> 3.7.1 #48766

Closed
wants to merge 1 commit into from
Closed

python37: 3.7.0 -> 3.7.1 #48766

wants to merge 1 commit into from

Conversation

dirn
Copy link
Contributor

@dirn dirn commented Oct 21, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dirn dirn requested a review from FRidh as a code owner October 21, 2018 02:34
@dirn
Copy link
Contributor Author

dirn commented Oct 21, 2018

If I should have used a branch like staging or staging-next, let me know and I'll change it (or you should be able to edit it as well).

@FRidh
Copy link
Member

FRidh commented Oct 21, 2018

Thanks. I pushed this already to staging.

@FRidh FRidh closed this Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dirn @FRidh @GrahamcOfBorg