Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mint: 0.2.1 -> 0.3.1 #47586

Merged
merged 1 commit into from Oct 1, 2018
Merged

mint: 0.2.1 -> 0.3.1 #47586

merged 1 commit into from Oct 1, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Oct 1, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@manveru
Copy link
Contributor Author

manveru commented Oct 1, 2018

I would love to compile mint using crystal build --static to reduce closure size, but can't get it to build :(

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

@GrahamcOfBorg build mint

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mint

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: mint

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mint

Partial log (click to expand)

gcc "${@}" -o '/nix/store/faphrq0h8nyiz1vc6irsd8kjc3n8acdm-mint-0.3.1/bin/mint'  -rdynamic  -lyaml `command -v pkg-config > /dev/null && pkg-config --libs --silence-errors libssl || printf %s '-lssl -lcrypto'` `command -v pkg-config > /dev/null && pkg-config --libs --silence-errors libcrypto || printf %s '-lcrypto'` -L/build/source/tmp/lib/duktape/src/.build/lib -L/build/source/tmp/lib/duktape/src/.build/include -lduktape -lm -lz -lpcre -lm -lgc -lpthread /nix/store/sqbpy4v88whsjnwfsspsmwixvkdqynyg-crystal-0.26.0/lib/crystal/ext/libcrystal.a -levent -lrt -ldl -L/usr/lib -L/usr/local/lib _main.o
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/faphrq0h8nyiz1vc6irsd8kjc3n8acdm-mint-0.3.1
shrinking /nix/store/faphrq0h8nyiz1vc6irsd8kjc3n8acdm-mint-0.3.1/bin/mint
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/faphrq0h8nyiz1vc6irsd8kjc3n8acdm-mint-0.3.1/bin
patching script interpreter paths in /nix/store/faphrq0h8nyiz1vc6irsd8kjc3n8acdm-mint-0.3.1
checking for references to /build in /nix/store/faphrq0h8nyiz1vc6irsd8kjc3n8acdm-mint-0.3.1...
/nix/store/faphrq0h8nyiz1vc6irsd8kjc3n8acdm-mint-0.3.1

@xeji xeji merged commit c4ff366 into NixOS:master Oct 1, 2018
@manveru manveru deleted the upgrade-mint-0.3.1 branch December 12, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @xeji @GrahamcOfBorg