Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: magithub and magit-svn require git #47576

Merged
merged 1 commit into from Oct 1, 2018
Merged

emacs: magithub and magit-svn require git #47576

merged 1 commit into from Oct 1, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Packages are broken without git.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: emacs

Partial log (click to expand)

copying path '/nix/store/r9iv5fn17xlhx5xr0v9yyaqwvs9yq5fd-util-linux-2.32.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/fhi4vzra9qrdv1vfm6k4hi2xxsgcli0k-pango-1.42.4' from 'https://cache.nixos.org'...
copying path '/nix/store/kcdgk5ww9h7amv7vk4bmsl2qlhv33z2r-systemd-239' from 'https://cache.nixos.org'...
copying path '/nix/store/kq62ivvh4iz4l9sbq1jzssczg1nxm2yb-librsvg-2.42.4' from 'https://cache.nixos.org'...
copying path '/nix/store/6bdigqp6g15jmiqgk6pbm8l1zmjf9sdk-dbus-1.12.10' from 'https://cache.nixos.org'...
copying path '/nix/store/5zfa8bx9n33km78k8bmbp8k6x0n7cm15-at-spi2-core-2.28.0' from 'https://cache.nixos.org'...
copying path '/nix/store/y9c4jyzspvqz3m6vbga39xbycp9ggmmp-at-spi2-atk-2.26.2' from 'https://cache.nixos.org'...
copying path '/nix/store/njngm02qd0zl0whzr17d3ai74b26wxnl-gtk+3-3.22.30' from 'https://cache.nixos.org'...
copying path '/nix/store/q89kybpcw7ybskkkkv7rgl3xr7ynh7f6-emacs-26.1' from 'https://cache.nixos.org'...
/nix/store/q89kybpcw7ybskkkkv7rgl3xr7ynh7f6-emacs-26.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: emacs

Partial log (click to expand)

these paths will be fetched (42.42 MiB download, 151.52 MiB unpacked):
  /nix/store/aa1g52ghahbbb732ii99zmzryi8d7zs4-emacs-26.1
  /nix/store/dcs7dxayg8jv9wal1rnfd4g7kq6b34nv-m17n-lib-1.8.0
  /nix/store/lrvz44bvm5968kf954d6xvmkqqmf8km8-m17n-db-1.8.0
  /nix/store/paljixf4p42jz1prxgbq6zbphn4j38g4-libotf-0.9.16
copying path '/nix/store/paljixf4p42jz1prxgbq6zbphn4j38g4-libotf-0.9.16' from 'https://cache.nixos.org'...
copying path '/nix/store/lrvz44bvm5968kf954d6xvmkqqmf8km8-m17n-db-1.8.0' from 'https://cache.nixos.org'...
copying path '/nix/store/dcs7dxayg8jv9wal1rnfd4g7kq6b34nv-m17n-lib-1.8.0' from 'https://cache.nixos.org'...
copying path '/nix/store/aa1g52ghahbbb732ii99zmzryi8d7zs4-emacs-26.1' from 'https://cache.nixos.org'...
/nix/store/aa1g52ghahbbb732ii99zmzryi8d7zs4-emacs-26.1

@peterhoeg peterhoeg merged commit 1f25518 into NixOS:master Oct 1, 2018
@peterhoeg peterhoeg deleted the f/magit branch October 1, 2018 04:05
@peterhoeg peterhoeg restored the f/magit branch October 1, 2018 06:58
@peterhoeg peterhoeg deleted the f/magit branch October 8, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @GrahamcOfBorg