ckb-next: from 0.2.9 0 -> 0.3.1 #47597
Conversation
Update to new release. Changed to cmake. Added udev rules for /dev/input/by-id/ to give keyboard consistent name (for VM input, etc.)
| (substituteAll { | ||
| name = "ckb-modprobe.patch"; | ||
| src = ./ckb-modprobe.patch; | ||
| inherit kmod; | ||
| }) | ||
| ./daemon.patch |
There was a problem hiding this comment.
Are you able to document these patches and submit them upstream if possible?
There was a problem hiding this comment.
Are these comments sufficient? The part that calls modprobe could be fixed to just load the module directly in C, and the cmake files could be changed to take some options for installation directories instead of hardcoding, but these are needed as it is now.
There was a problem hiding this comment.
Have you submitted an upstream issue for that?
pkgs/tools/misc/ckb/default.nix
Outdated
| ]; | ||
|
|
||
| doCheck = false; | ||
|
|
||
| installPhase = '' | ||
| runHook preInstall | ||
| #installPhase = '' |
pkgs/tools/misc/ckb/default.nix
Outdated
| name = "udev_rules.patch"; | ||
| src = ./udev_rules.patch; | ||
| inherit gnused; | ||
| }) | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
It would be nice to document why checks are disabled.
There was a problem hiding this comment.
I don't know why that was put there before but it is fine without for me.
There was a problem hiding this comment.
That is because false is actually the default. What happens if you set it to true?
There was a problem hiding this comment.
That is because false is actually the default. What happens if you set it to true explicitly?
| @@ -23,33 +23,33 @@ stdenv.mkDerivation rec { | |||
| ]; | |||
|
|
|||
| patches = [ | |||
|
|
|||
| # ckb daemon loads a kernel module by calling the actual modprobe binary | |||
There was a problem hiding this comment.
Whats wrong about the "actual modprobe binary"?
| (substituteAll { | ||
| name = "ckb-modprobe.patch"; | ||
| src = ./ckb-modprobe.patch; | ||
| inherit kmod; | ||
| }) | ||
| ./daemon.patch |
There was a problem hiding this comment.
Have you submitted an upstream issue for that?
| ./dev_name.patch | ||
| #Update udev rules for /dev/input/by-id. remove on next ckb release. | ||
|
|
||
| ./dev_name.patch # add correct device alias (mouse vs keyboard) |
|
|
||
| ./dev_name.patch # add correct device alias (mouse vs keyboard) | ||
|
|
||
| # ckb's udev rule runs sed on device name for some reason |
There was a problem hiding this comment.
And this patch reverts that behaviour? Why?
pkgs/tools/misc/ckb/default.nix
Outdated
| name = "udev_rules.patch"; | ||
| src = ./udev_rules.patch; | ||
| inherit gnused; | ||
| }) | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
That is because false is actually the default. What happens if you set it to true explicitly?
|
Please note that #40043 already exists (although it was outdated at the time this PR was created). Are the udev rule changes required for the package upgrade, or are they a separate change? |
|
Closing since #40043 got merged |
Update to new release. Changed to cmake. Added udev rules for
/dev/input/by-id/ to give keyboard consistent name (for VM input, etc.)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)