Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools: Use nix instead of nixUnstable #47582

Merged
merged 1 commit into from Oct 1, 2018
Merged

dockerTools: Use nix instead of nixUnstable #47582

merged 1 commit into from Oct 1, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Oct 1, 2018 •
edited

Motivation for this change

I believe the usage of nixUnstable is an oversight since the original 2.x bump.
This should probably be backported to 18.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Oct 1, 2018

@GrahamcOfBorg build dockerTools.examples

@srhb
Copy link
Contributor Author

srhb commented Oct 1, 2018

@GrahamcOfBorg test docker-tools

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.docker-tools

No partial log is available.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dockerTools.examples

Partial log (click to expand)

in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

/nix/store/a20nppcwg1b5pkwfpf65p6k5n9a630sl-docker-image-bash.tar.gz.drv
/nix/store/xrd3jl5isg7pwcjymkbvn1a3q26h9aiv-docker-image-editors.tar.gz.drv
/nix/store/0k2xlw8ynmrwl4n4nf26yqj0j80pi2s3-docker-image-layered-image.tar.gz.drv

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dockerTools.examples

Partial log (click to expand)

/nix/store/k5nnxlaymrr85h8gg82xxhi5ylqv7yay-docker-image-bash.tar.gz
/nix/store/j5iy6y56k3gikpf710bggjnzipavr20n-docker-image-editors.tar.gz
/nix/store/ifvn0agql1nh7zrl0gvmzna2vs5vc6yj-docker-image-layered-image.tar.gz
/nix/store/88dq0sjx39985cszy7gbcy0q5byxw8vk-docker-image-nginx-container.tar.gz
/nix/store/2x504x1s0n4lkymk6p8ndsw9xl4wnlr2-docker-image-nix.tar.gz
/nix/store/ljdhshpv3yp3wkpvspj054bns4psh007-docker-image-nixos-nix-1.11.tar
/nix/store/89yj37lnq9clhsdq6lhfffv1awllfcwk-docker-image-onTopOfPulledImage.tar.gz
/nix/store/n3ahn642nv13419i9aixnh2c78j8pa1b-docker-image-redis.tar.gz
/nix/store/ncmsamki96dxmsr5ggdsjq3s0a2j5167-docker-image-runAsRootExtraCommands.tar.gz
/nix/store/1a33ccbclb29d1g7jy88c01fv4k5il04-docker-image-unstable-date.tar.gz

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.docker-tools

Partial log (click to expand)

syncing
docker: running command: sync
docker# [  104.622666] dhcpcd[792]: veth762dfe1: removing interface
docker: exit status 0
test script finished in 106.16s
cleaning up
killing docker (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/wx27r2pcrmw7gchxlsj1c2nnj1d59x7h-vm-test-run-docker-tools

@nlewo
Copy link
Member

nlewo commented Oct 1, 2018

Yes, it is!

@nlewo nlewo merged commit 976edf1 into NixOS:master Oct 1, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: dockerTools.examples

Partial log (click to expand)

cannot build derivation '/nix/store/bad006sb36cp9n6y4dzmg03v7nbr21ay-docker-layer-nginx-container.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/32h3kw0xlwa1glrcxp978jaq5yw8xf77-docker-layer-redis.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6gk18szh7b7n6rszcni9nvxcy4f14hqg-docker-layer-runAsRootExtraCommands.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4pqg4sy61p3gnh8145pvmprigblahraa-runtime-deps.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lhmxi2gy6v2ayxidqrybpg45h15knizx-runtime-deps.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rsf7q9rkhkc9z043ky2cckjb5lxx6c0b-runtime-deps.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0ix5f27n2z0825znj8hz071jjzjxnryj-docker-image-nginx-container.tar.gz.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jzids872w4j0kkqa612b72ds929pvibj-docker-image-redis.tar.gz.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/cn158fic59am8prvk6zg3lmhmgbk3jxl-docker-image-runAsRootExtraCommands.tar.gz.drv': 2 dependencies couldn't be built
error: build of '/nix/store/0ix5f27n2z0825znj8hz071jjzjxnryj-docker-image-nginx-container.tar.gz.drv', '/nix/store/7yc3rs4s025miymhg6mb9dwqvha6zadd-docker-image-unstable-date.tar.gz.drv', '/nix/store/cn158fic59am8prvk6zg3lmhmgbk3jxl-docker-image-runAsRootExtraCommands.tar.gz.drv', '/nix/store/jdq36lv1wynn6wcraczv11xzf437vaq8-docker-image-editors.tar.gz.drv', '/nix/store/jzids872w4j0kkqa612b72ds929pvibj-docker-image-redis.tar.gz.drv', '/nix/store/kg50miv5ray6dsqihr4c71gqj372lpka-docker-image-onTopOfPulledImage.tar.gz.drv', '/nix/store/kr5x8mzxrkwg6na7jwf58j0kvqchk146-docker-image-nix.tar.gz.drv', '/nix/store/l1k8gfygxqlfnrs3y3qr3cmj2p64ia66-docker-image-bash.tar.gz.drv', '/nix/store/z87vkc7fybczzb986zn26ckld6gysnaf-docker-image-layered-image.tar.gz.drv' failed

@nlewo
Copy link
Member

nlewo commented Oct 1, 2018

backported in ff37ba7

@srhb srhb deleted the dockerTools-nix-stable branch October 1, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @GrahamcOfBorg @nlewo