Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TBS: fix modules #47596

Merged
merged 1 commit into from
Nov 14, 2018
Merged

TBS: fix modules #47596

merged 1 commit into from
Nov 14, 2018
+1 −2

Conversation

cillianderoiste
Copy link
Member

The customized modules need to be xz compressed so that they are
loaded instead of the default modules

Motivation for this change

Fix the TBS module so that the tuner can scan and lock successfully.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@cillianderoiste
TBS: fix modules
85c236f 
The customized modules need to be xz compressed so that they are
loaded instead of the default modules
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 1, 2018
@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

@GrahamcOfBorg build linuxPackages.tbs linuxPackages_latest.tbs

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.tbs, linuxPackages_latest.tbs

Partial log (click to expand)

while evaluating the attribute 'linux_4_18' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14125:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14125:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.18.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14419:16, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.18.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14419:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:51:1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: linuxPackages.tbs

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages_latest.tbs

Partial log (click to expand)

make[5]: *** [/nix/store/384gzgiypyg8hbb1klbk8j25hxby9gf8-linux-4.14.73-dev/lib/modules/4.14.73/source/scripts/Makefile.build:329: /build/media_build/v4l/hfi.o] Error 1
make[4]: *** [/nix/store/384gzgiypyg8hbb1klbk8j25hxby9gf8-linux-4.14.73-dev/lib/modules/4.14.73/source/Makefile:1527: _module_/build/media_build/v4l] Error 2
make[3]: *** [Makefile:146: sub-make] Error 2
make[2]: *** [Makefile:24: __sub-make] Error 2
make[2]: Leaving directory '/nix/store/384gzgiypyg8hbb1klbk8j25hxby9gf8-linux-4.14.73-dev/lib/modules/4.14.73/build'
make[1]: *** [Makefile:53: default] Error 2
make[1]: Leaving directory '/build/media_build/v4l'
make: *** [Makefile:26: all] Error 2
builder for '/nix/store/namgcqqg7nhcfmy11a5svcv9lgcwl7jv-tbs-2018.04.18-4.14.73.drv' failed with exit code 2
error: build of '/nix/store/namgcqqg7nhcfmy11a5svcv9lgcwl7jv-tbs-2018.04.18-4.14.73.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: linuxPackages.tbs

The following builds were skipped because they don't evaluate on x86_64-linux: linuxPackages_latest.tbs

Partial log (click to expand)

  LD [M]  /build/media_build/v4l/rc-azurewave-ad-tu700.ko
  CC      /build/media_build/v4l/rc-behold-columbus.mod.o
  LD [M]  /build/media_build/v4l/rc-behold-columbus.ko
  CC      /build/media_build/v4l/rc-behold.mod.o
  LD [M]  /build/media_build/v4l/rc-behold.ko
  CC      /build/media_build/v4l/rc-budget-ci-old.mod.o
  LD [M]  /build/media_build/v4l/rc-budget-ci-old.ko
  CC      /build/media_build/v4l/rc-cec.mod.o
building of '/nix/store/f1pwa1fadxa8391px63qj7sqczm64m45-tbs-2018.04.18-4.14.73.drv' timed out after 3600 seconds
error: build of '/nix/store/f1pwa1fadxa8391px63qj7sqczm64m45-tbs-2018.04.18-4.14.73.drv' failed

@cillianderoiste cillianderoiste merged commit ad18c54 into NixOS:master Nov 14, 2018
@cillianderoiste cillianderoiste deleted the tbs-fix branch November 14, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cillianderoiste @xeji @GrahamcOfBorg