sourcetrail: init at 2018.3.55 #47594

midchildan · 2018-10-01T11:53:46Z

Motivation for this change

Sourcetrail is a cross referencer for C/C++/Java

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

midchildan · 2018-10-01T12:00:41Z

pkgs/development/tools/sourcetrail/default.nix

+      $out/share/applications/sourcetrail.desktop \
+      --replace /usr/bin/ $out/bin/
+
+    # FIXME: not working


I can't seem to change the permission of default configuration files that are copied to the user's home directory upon first launch. Does anyone have a clue why this is happening?

Everything in the nix store is always read only.

@symphorien Do you mean even during installPhase ?

When the build is over, $out will be made read only.

Mic92 · 2018-10-01T23:24:24Z

pkgs/development/tools/sourcetrail/default.nix

+
+  dontBuild = true;
+
+  nativeBuildInputs = [ makeWrapper ];


I have a simplified version using autoPatchelfHook:
https://github.com/Mic92/nur-packages/blob/master/pkgs/sourcetrail/default.nix

This will be easier to maintain then manual patchelf/LD_LIBRARY_PATH.

Have you considered moving this to nixpkgs?

No, I don't use it and do not have a license.

I will remove it from NUR once it lands in nixpkgs.

midchildan · 2018-10-22T14:21:06Z

I made some changes based on @Mic92's version. I still couldn't figure out how to change permissions for the initial configuration files, so I made a wrapper command that manually copies those files on first launch.

Mic92 · 2018-10-22T14:47:43Z

pkgs/development/tools/sourcetrail/default.nix

+
+    cat <<EOF > $out/bin/sourcetrail
+      #! ${stdenv.shell} -e
+      mkdir -p ~/.config/sourcetrail


This should be skipped if $HOME is not set. Sourcetrail does not use the fallback configuration from its package itself?

It does, but it gets copied into the home directory without write permissions. I've tried setting write permissions for the original copy during installPhase, but then I got a "Permission denied" error.

Mic92 · 2018-10-22T14:48:41Z

pkgs/development/tools/sourcetrail/default.nix

+    mv -v plugin $out/share/sourcetrail
+
+    cp -rv . $out/opt
+    rm $out/opt/lib/libssl.so


Does a symlink works here? Then LD_LIBRARY_PATH becomes unnecessary.

Mic92 · 2018-10-22T21:02:28Z

pkgs/development/tools/sourcetrail/default.nix

+      $out/share/applications/sourcetrail.desktop \
+      --replace /usr/bin/ $out/bin/
+
+    cat <<EOF > $out/bin/sourcetrail


The variables here are expanded at build time: The wrapper currently contains /homeless-shelter instead of $HOME.

Thanks, that explains the problems I was having with the wrapper script.

midchildan · 2018-10-29T18:31:44Z

With the wrapper script taking care of the permission problem, things seem to work okay now. It should be ready for merge.

Mic92 · 2018-10-30T12:07:38Z

It does not yet work for java. I think this could become another pull request:

https://dl.thalheim.io/WOpRngYvf_rmV1TEZL8Ehw/Screenshot_20181030_120612.png

maybe @egraether can give us a hint how sourcetrail tries to figure out where java is.
JAVA_HOME is not enough apparently.

Mic92 · 2018-10-30T12:13:09Z

Ok there is a setting to specify this manually. However dlopen fails here for some reason:

Sourcetrail was unable to locate Java on this machine.
Please make sure to provide the correct Java Path in the preferences.

Error: Could not load library "/nix/store/5lcwd2h26m64f8hln9b3m29jprl06n5y-openjdk-8u181b13/lib/openjdk/jre/lib/amd64/server/libjvm.so"

egraether · 2018-11-02T13:07:20Z

On first start Sourcetrail tries to find the java installation with which java, then by looking at $JAVA_HOME, then some standard locations. If the libjvm.so library is found, then that path is automatically set. Otherwise you can enter it manually in the preferences.

If the dlopen fails then the only reason I can think of is that Sourcetrail and the Java library are built for different architectures. Are you using the 64bit Sourcetrail build?

Mic92 · 2018-11-02T15:40:56Z

pkgs/development/tools/sourcetrail/default.nix

+
+  src = fetchurl {
+    name = "sourtrail.tar.gz";
+    url = "https://www.sourcetrail.com/downloads/${version}/linux/64bit";


This should be the 64-bit version. jdk is also 64-bit of course.

midchildan commented Oct 1, 2018

View reviewed changes

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Oct 1, 2018

Mic92 reviewed Oct 1, 2018

View reviewed changes

midchildan force-pushed the add-sourcetrail branch from 0268783 to 8d335f4 Compare October 18, 2018 08:11

GrahamcOfBorg added the 2.status: merge conflict label Oct 18, 2018

midchildan force-pushed the add-sourcetrail branch 2 times, most recently from 72618c3 to 29d0653 Compare October 22, 2018 11:35

Mic92 reviewed Oct 22, 2018

View reviewed changes

GrahamcOfBorg removed the 2.status: merge conflict label Oct 22, 2018

Mic92 reviewed Oct 22, 2018

View reviewed changes

sourcetrail: init at 2018.3.55

444ce2d

midchildan force-pushed the add-sourcetrail branch from c379577 to 444ce2d Compare October 23, 2018 02:39

Mic92 merged commit d23d25e into NixOS:master Oct 30, 2018

Mic92 reviewed Nov 2, 2018

View reviewed changes

midchildan deleted the add-sourcetrail branch September 19, 2020 12:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sourcetrail: init at 2018.3.55 #47594

sourcetrail: init at 2018.3.55 #47594

midchildan commented Oct 1, 2018

midchildan Oct 1, 2018

symphorien Oct 1, 2018

midchildan Oct 1, 2018

symphorien Oct 1, 2018

Mic92 Oct 1, 2018

midchildan Oct 2, 2018

Mic92 Oct 3, 2018

Mic92 Oct 3, 2018

midchildan commented Oct 22, 2018 •

edited

Mic92 Oct 22, 2018 •

edited

midchildan Oct 22, 2018

Mic92 Oct 22, 2018

Mic92 Oct 22, 2018 •

edited

midchildan Oct 23, 2018

midchildan commented Oct 29, 2018

Mic92 commented Oct 30, 2018 •

edited

Mic92 commented Oct 30, 2018

egraether commented Nov 2, 2018

Mic92 Nov 2, 2018

sourcetrail: init at 2018.3.55 #47594

sourcetrail: init at 2018.3.55 #47594

Conversation

midchildan commented Oct 1, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

midchildan commented Oct 22, 2018 • edited

Mic92 Oct 22, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 Oct 22, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

midchildan commented Oct 29, 2018

Mic92 commented Oct 30, 2018 • edited

Mic92 commented Oct 30, 2018

egraether commented Nov 2, 2018

Choose a reason for hiding this comment

midchildan commented Oct 22, 2018 •

edited

Mic92 Oct 22, 2018 •

edited

Mic92 Oct 22, 2018 •

edited

Mic92 commented Oct 30, 2018 •

edited