Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plantuml: 1.2018.10 -> 1.2018.11 #47587

Merged
merged 1 commit into from Oct 1, 2018
Merged

plantuml: 1.2018.10 -> 1.2018.11 #47587

merged 1 commit into from Oct 1, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Instead of manually hacking together a wrapper script, just use makeWrapper instead.

Cc: @bjornfor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: plantuml

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: plantuml

Partial log (click to expand)

    -splash             To display a splash screen with some progress bar
    -progress           To display a textual progress bar in console
/nix/store/2xwxhia7179w19dqq8arhv28r3z6kg2n-plantuml-1.2018.11
    -pipeimageindex N   To generate the Nth image with pipe option
    -stdlib             To print standart library info
    -extractstdlib      To extract PlantUML Standard Library into stdlib folder
    -filename "example.puml"    To override %filename% variable
    -preproc            To output preprocessor text of diagrams

If needed, you can setup the environment variable GRAPHVIZ_DOT.

@peterhoeg peterhoeg merged commit ae2bb82 into NixOS:master Oct 1, 2018
@peterhoeg peterhoeg deleted the u/plantuml branch October 1, 2018 12:24
@peterhoeg peterhoeg restored the u/plantuml branch October 2, 2018 09:05
@peterhoeg peterhoeg deleted the u/plantuml branch October 8, 2018 01:26
@peterhoeg peterhoeg restored the u/plantuml branch October 8, 2018 11:46
@peterhoeg peterhoeg deleted the u/plantuml branch March 18, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @bjornfor