Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 2018-08-30 -> 2018-09-29 #47579

Closed
wants to merge 1 commit into from
Closed

alacritty: 2018-08-30 -> 2018-09-29 #47579

wants to merge 1 commit into from

Conversation

wykurz
Copy link
Contributor

@wykurz wykurz commented Oct 1, 2018

Motivation for this change

Updating alacritty to master as of 2018-09-29.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Mic92

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2018

See #46807

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2018

I will do an upgrade here: #47591 (also we already have the same version without my fork in staging).
Let me know, if you still want to be in the maintainer list.

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2018

The other pull request is merged. You can add yourself as maintainer if you want.

@wykurz
Copy link
Contributor Author

wykurz commented Oct 1, 2018 via email

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

closing, superseded

@xeji xeji closed this Oct 1, 2018
@wykurz wykurz deleted the mateusz/alacritty-update branch October 12, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wykurz @Mic92 @xeji @GrahamcOfBorg @Janik-Haag