Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/nix-ssh-serve.nix: Use stable nix #47584

Merged
merged 1 commit into from Oct 1, 2018
Merged

nixos/tests/nix-ssh-serve.nix: Use stable nix #47584

merged 1 commit into from Oct 1, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Oct 1, 2018 •
edited

Motivation for this change

Stable Nix supports ssh-ng since 2.x.
Should be backported to 18.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Oct 1, 2018

@GrahamcOfBorg test nix-ssh-serve

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nix-ssh-serve

Partial log (click to expand)

server# [   36.466496] systemd[1]: Stopped User Manager for UID 104.
server# [   36.467764] systemd[1]: user-runtime-dir@104.service: Unit not needed anymore. Stopping.
client: exit status 0
test script finished in 37.85s
cleaning up
killing server (pid 631)
killing client (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/vc3qyvd2hlgx8nrc7qx9hngsa5wb5w2k-vm-test-run-nix-ssh-serve

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nix-ssh-serve

Partial log (click to expand)

server# [   27.140823] systemd[1]: user-runtime-dir@104.service: Unit not needed anymore. Stopping.
server# [   27.160597] systemd[1]: Stopped User Manager for UID 104.
client: exit status 0
test script finished in 29.37s
cleaning up
killing server (pid 597)
killing client (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/z1id9d94rjxdrx4h1ww6i20pv82whmns-vm-test-run-nix-ssh-serve

@xeji xeji merged commit 358a1c8 into NixOS:master Oct 1, 2018
xeji pushed a commit that referenced this pull request Oct 1, 2018
@srhb @xeji
nixos/tests/nix-ssh-serve.nix: Use stable nix (#47584)
a54dadb 
(cherry picked from commit 358a1c8)
@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

backported: a54dadb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @GrahamcOfBorg @xeji