opensm: 3.3.20 -> 3.3.21 #47732

markuskowa · 2018-10-03T11:01:52Z

Motivation for this change

Old git source repository was dead. Switched to GitHub. Update to new version.

CC @aij

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Old git source repository was dead. Switched to GitHub

GrahamcOfBorg · 2018-10-03T11:14:05Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: opensm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-03T11:15:05Z

Success on x86_64-linux (full log)

Attempted: opensm

Partial log (click to expand)

shrinking /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/sbin/osmtest
shrinking /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/sbin/opensm
gzipping man pages under /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/share/man/
/nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/lib  /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/sbin
patching script interpreter paths in /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21
/nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/etc/init.d/opensmd: interpreter directive changed from "/bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21...
moving /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/sbin/* to /nix/store/fpldjfpxrzal0cpdgnf6vrp9r4asb1r6-opensm-3.3.21/bin

c0bw3b · 2018-10-08T19:05:12Z

pkgs/tools/networking/opensm/default.nix

@@ -16,6 +17,8 @@ stdenv.mkDerivation rec {

  preConfigure = "bash ./autogen.sh";


Not sure if this might be a source of problems but this could be simpler:

preConfigure = "./autogen.sh"

Let it be run in the current build env (sandboxed) with the current shell.

It should not cause problems but I agree that it is unnecessary.

Won't patchShebangs patch it to use bash from the target env instead of the build/native env?

I would expect the bash on the path during the build (preConfigure) to be the one from the build env. Is it not?

You mean in a cross compilation environment? That is a good point. I am not sure how that would be handled. The manual does not mention this case (?) Using patchShebangs to patch the build environment is rather common though. In some cases there are bunch of scripts, such that patchShebangs seems to be the obvious choice to fix the build env.

Yes it's done in plenty of packages.
At the moment the source states:

This setup hook [...] rewrite(s) all script interpreter file names to paths found in $PATH

Seems safe to use it that way.

@c0bw3b I am still curious what would actually happen in a cross environment. nativeBuildInputs and buildInputs determine what should be run time and what should be pure build time dependency. These parts should be clear then. However, bash is part of the build env, such that the fixupPhase would write a bash into scripts that belongs to the build env instead the target env?
I am sure nix has some magic going on that fixes it correctly but it is not obvious to me.

The build env is sandboxed but still using a bash from the nix store, I'm guessing?

I'm not well-versed in cross-compilation matters but I see that one commit on patch-shebangs.sh to address cross-compile was then reverted.
In any way the nix function patchShebangs will "mask" the complexity and decide what to do when cross-compiling or not.

Aha

This setup hook causes the fixup phase to rewrite all script

[...]
`newPath="$(command -v "$(basename "$oldPath")" || true)"

So, as is, it should be fine to use for patching build scripts.

When executed during the fixup phase (in the target env), it will patch to use the target env, but when executed during preConfigure (in the build env), it will actually patch to use the build env.

There is the nix magic! Thanks for digging into it.

GrahamcOfBorg · 2018-10-08T19:32:55Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: opensm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-08T19:33:26Z

Failure on x86_64-linux (full log)

Attempted: opensm

Partial log (click to expand)

copying path '/nix/store/6xyhmj341yd2182977g9j17jr5nhfg4j-rdma-core-20' from 'https://cache.nixos.org'...
building '/nix/store/7667vpk28h7lakp9lrdhw4q26s8mvb6p-opensm-3.3.21.drv'...
unpacking sources
unpacking source archive /nix/store/108rk5hb9w44rrmb0aizn1fmylg3a4b1-source
source root is source
patching sources
configuring
/nix/store/2hjlb5wim3ghl2p1r65bb49y06ckd3g1-stdenv-linux/setup: ./autogen.sh: /bin/bash: bad interpreter: No such file or directory
builder for '/nix/store/7667vpk28h7lakp9lrdhw4q26s8mvb6p-opensm-3.3.21.drv' failed with exit code 126
error: build of '/nix/store/7667vpk28h7lakp9lrdhw4q26s8mvb6p-opensm-3.3.21.drv' failed

GrahamcOfBorg · 2018-10-08T19:57:13Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: opensm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-08T19:59:55Z

Success on x86_64-linux (full log)

Attempted: opensm

Partial log (click to expand)

shrinking /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/sbin/opensm
shrinking /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/sbin/osmtest
gzipping man pages under /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/lib  /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/sbin
patching script interpreter paths in /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21
/nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/etc/init.d/opensmd: interpreter directive changed from "/bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21...
moving /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/sbin/* to /nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21/bin
/nix/store/304m5agfr9971g1zp69kkgz1sjkk0yx9-opensm-3.3.21

c0bw3b

LGTM

aij

LGTM

7c6f434c · 2018-10-13T06:15:24Z

@domenkozar @rbvermaa @edolstra https://discourse.nixos.org/t/the-best-way-to-attract-attention-to-issues-and-pull-requests/1130/14 — giving @markuskowa commit access is indeed a good idea.

opensm: 3.3.20 -> 3.3.21

ced5563

Old git source repository was dead. Switched to GitHub

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Oct 3, 2018

c0bw3b reviewed Oct 8, 2018

View reviewed changes

opensm: use native shell to run autogen.sh

e6c947a

markuskowa force-pushed the opensm-up branch from 5676af9 to e6c947a Compare October 8, 2018 19:43

c0bw3b approved these changes Oct 8, 2018

View reviewed changes

aij approved these changes Oct 10, 2018

View reviewed changes

7c6f434c merged commit c60e8f4 into NixOS:master Oct 13, 2018

markuskowa deleted the opensm-up branch October 13, 2018 07:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

opensm: 3.3.20 -> 3.3.21 #47732

opensm: 3.3.20 -> 3.3.21 #47732

markuskowa commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

c0bw3b Oct 8, 2018

markuskowa Oct 8, 2018

aij Oct 9, 2018

markuskowa Oct 9, 2018

c0bw3b Oct 9, 2018

markuskowa Oct 9, 2018

c0bw3b Oct 9, 2018

aij Oct 10, 2018

markuskowa Oct 10, 2018

GrahamcOfBorg commented Oct 8, 2018

GrahamcOfBorg commented Oct 8, 2018

GrahamcOfBorg commented Oct 8, 2018

GrahamcOfBorg commented Oct 8, 2018

c0bw3b left a comment

aij left a comment

7c6f434c commented Oct 13, 2018

		@@ -16,6 +17,8 @@ stdenv.mkDerivation rec {

		preConfigure = "bash ./autogen.sh";

opensm: 3.3.20 -> 3.3.21 #47732

opensm: 3.3.20 -> 3.3.21 #47732

Conversation

markuskowa commented Oct 3, 2018

Motivation for this change

Things done

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This setup hook causes the fixup phase to rewrite all script

Choose a reason for hiding this comment

GrahamcOfBorg commented Oct 8, 2018

GrahamcOfBorg commented Oct 8, 2018

GrahamcOfBorg commented Oct 8, 2018

GrahamcOfBorg commented Oct 8, 2018

c0bw3b left a comment

Choose a reason for hiding this comment

aij left a comment

Choose a reason for hiding this comment

7c6f434c commented Oct 13, 2018