lsp-plugins: init at 1.1.4 #47694
lsp-plugins: init at 1.1.4 #47694
Conversation
| substituteInPlace ./include/container/vst/main.h --replace "/usr/lib" "$out/lib" | ||
| ''; | ||
|
|
||
| buildPhase = "make all && make release"; |
There was a problem hiding this comment.
please use buildFlags instead of overriding buildPhase
| ''; | ||
|
|
||
| buildPhase = "make all && make release"; | ||
|
|
There was a problem hiding this comment.
In that case please set doCheck = true; to run the tests.
There was a problem hiding this comment.
I've added that, but the build output doesn't indicate it's running any tests afaik.
There was a problem hiding this comment.
By default, when you set doCheck = true; it will run make check. If that's not the name of the target, you can change that by setting checkTarget = "all-tests"; or whatever the relevant make target is.
There was a problem hiding this comment.
I have it building tests now, but it looks like these tests are meant to be ran manually.
Shall I remove the tests all-together, or run them somehow?
There was a problem hiding this comment.
You can override checkPhase if there isn't a way to invoke it via make. From a cursory glance at the link you mentioned, based on this:
If we don's specify any unit test name in argument, then all available unit tests will be launched.
You should be able to do something like this to run the unit tests:
checkPhase = ''
runHook preCheck
.build/lsp-plugins-test utest
runHook postCheck
'';
magnetophon
force-pushed
the
lsp-plugins
branch
from
76358b1
to
fecb574
Compare
|
@peterhoeg Thanks for your feedback. Could you take a look at #47382 as well? |
magnetophon
force-pushed
the
lsp-plugins
branch
from
fecb574
to
15b513d
Compare
magnetophon
force-pushed
the
lsp-plugins
branch
from
15b513d
to
f14c0b4
Compare
|
Thank your for you contribution and being open to all the feedback! |
|
Thanks for all the feedback! :) |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)