Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: fix build with rustc that supports aarch64-fuchsia #47734

Closed

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Thunderbird is broken! See upstream report for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@thefloweringash thefloweringash changed the title thunderbird: fix build with rustc that supports aarch64-fuschia thunderbird: fix build with rustc that supports aarch64-fuchsia Oct 3, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 3, 2018

Does this also affect stable?

@andir
Copy link
Member

andir commented Oct 3, 2018

The PR #47748 pulled in the exact same changes (https://github.com/NixOS/nixpkgs/pull/47748/files#diff-9acfd6a4d3746d2b6cafcec20d2414aaR52). Not sure if this was inspired by this PR.

@thefloweringash Thanks for the work & PR but I think we can close this? :-)

@thefloweringash thefloweringash deleted the thunderbird-rustc-fix branch October 3, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants