Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle two-part KSP-AVC versions #2532

Merged
merged 1 commit into from
Oct 7, 2018

Conversation

HebaruSan
Copy link
Member

Problem

CKAN has pretty excellent handling for two-part game versions (e.g., "1.3" or "1.4") thanks to #1645, but to use it with a .version file you need to use a "-1" wildcard, as in:

	"KSP_VERSION_MIN": {
		"MAJOR": 1,
		"MINOR": 3,
		"PATCH": -1
	},

Which is kind of awkward and not terribly well known. Simply leaving out PATCH will raise an error:

1382 [1] FATAL CKAN.NetKAN.Program (null) - One of the identified items was in an invalid format.

I tested that format with KSP-AVC itself, and it worked fine, so Netkan should handle it as well.

Changes

Now you can leave out PATCH, MINOR, or even MAJOR, and the wildcard will be assumed.

Fixes #1687.

@HebaruSan HebaruSan added Easy This is easy to fix Pull request Netkan Issues affecting the netkan data labels Oct 3, 2018
@politas politas merged commit 075f091 into KSP-CKAN:master Oct 7, 2018
politas added a commit that referenced this pull request Oct 7, 2018

Verified

This commit was signed with the committer’s verified signature.
@HebaruSan HebaruSan deleted the fix/netkan-two-part-kspversions branch October 7, 2018 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants