Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/matomo: introduce services.matomo.package option #47691

Merged
merged 1 commit into from Oct 13, 2018

Conversation

florianjacob
Copy link
Contributor

for e.g. being able to use an updated matomo from unstable or custom sources.

Motivation for this change

During 18.03's lifetime, I had several maintainership issues with Matomo releasing new versions that are not strictly security-relveant, but were still of crucial importance to a limited set of people.
The most prominent example was the GDPR update: If GDPR did not apply to you, you might would not want to risk the stability of your system, but for users in/targeting Europe, the update was crucial to be allowed to still operate a Matomo instance.

This option should allow me to be more strict on what's required for stable, as users really needing the update could easily get it from unstable with this option. The service definition itself is very unlikely to break with Matomo new releases, so this should just work.

Can we still get this into 18.09, at least eventually? I know I'm late, but this should not be able to break anything and help maintaining a stable Matomo during 18.09's lifetime.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be not an issue to have this in 18.09.

@florianjacob
Copy link
Contributor Author

Now that 18.09 is released, I moved the changelog entry to 19.03 as I suspect nobody will read the changelog again after updating.

@lukateras lukateras merged commit 6e4d0c4 into NixOS:master Oct 13, 2018
@florianjacob florianjacob deleted the matomo-choose-package branch October 15, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants