New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] gnuradio: 3.7.14.3 -> 3.8.0.0 #47707
Conversation
Can a known user run ofborg please? I have not built on OS X. |
Sorry, I have no time to test. And I'm not actively using gnuradio either, so not sure how to test beyond starting the GUI. Is tech preview like a release candidate? Or beta release? If so I'd prefer not to add v3.8 to nixpkgs before upstream makes a (real) release. |
It's a release candidate for their push from python2 to python3. I want to give people a chance to test. And due to the large number of breaking changes I expect to have to support both 3.7.X and 3.8 for a little while. |
Perhaps make this new version lowPrio then, until it gets a stable release? |
Sure, i don't have tagging/labeling rights. |
No, I meant to apply the |
dd5302a
to
693cb69
Compare
done |
I too think this should wait until 3.8 is not beta/release candidate/tech preview. I've made some tests in the past with programs that depend on Gnuradio and they didn't even succesfully compile with this version. |
Update: GNURadio 3.8 was officially release today: https://www.gnuradio.org/news/2019-08-10-gnu-radio-v3-8-0-0-release/ @tomberek would you like to try again to push this? I consider taking over this myself.. |
693cb69
to
9a413fb
Compare
Here's a new push with a version bump to 3.8.0.0. Still doesn't work right due to some Qt issues. Anyone familiar with Qt packaging and dependencies? Current symptoms, i can build and start
|
Have you tried using |
Yes I tried that, but I must have been using it incorrectly, or there is something else about Qt that I don’t understand. |
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
@tomberek are you going to work on this or can we close it? |
@SuperSandro2000 #99685 is much farther along, closing in favor of that PR. |
Motivation for this change
Update gnuradio to latest. This is a tech preview and update to python3, so I suspect we'll need to have both 3.7 and 3.8 in Nixpkgs for a bit.
Things done
Many changes to dependencies due to python2 -> python3 transition. Graphics libraries have changed. There is a hack in there about dist-packages, I'm working with upstream to fix that (gnuradio/gnuradio#2019).
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)