Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan-headers: 1.1.82.0 -> 1.1.85 #47702

Merged
merged 1 commit into from Oct 12, 2018
Merged

vulkan-headers: 1.1.82.0 -> 1.1.85 #47702

merged 1 commit into from Oct 12, 2018

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Oct 3, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vulkan-headers/versions.

meta.description for vulkan-headers is: '"Vulkan Header files and API registry"'.

Compare changes on GitHub

Checks done (click to expand)
Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

  1. Install cachix from https://cachix.org/
  2. Use r-ryantm's cache: 
    cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:

nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/3cc6b6518c8f77c7b1f3d75c00f453b5ca451fa2.tar.gz -p vulkan-headers
ls -la /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85

cc @Ralith for testing.

@r-ryantm
vulkan-headers: 1.1.82.0 -> 1.1.85
3cc6b65 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/vulkan-headers/versions
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vulkan-headers

Partial log (click to expand)

-- Installing: /nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85/share/vulkan/registry/reg.py
-- Installing: /nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85/share/vulkan/registry/genvk.py
-- Installing: /nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85/share/vulkan/registry/generator.py
-- Installing: /nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85/share/vulkan/registry/cgenerator.py
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85
checking for references to /build in /nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85...
/nix/store/imv819lh0rdbv5p9xlkycdgkvld1dz51-vulkan-headers-1.1.85

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vulkan-headers

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vulkan-headers

Partial log (click to expand)

-- Installing: /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85/share/vulkan/registry/reg.py
-- Installing: /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85/share/vulkan/registry/genvk.py
-- Installing: /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85/share/vulkan/registry/generator.py
-- Installing: /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85/share/vulkan/registry/cgenerator.py
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85
checking for references to /build in /nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85...
/nix/store/mlrrdsqh8ziscv77cz32sa98818sxv7s-vulkan-headers-1.1.85

@xeji xeji merged commit e6b0646 into NixOS:master Oct 12, 2018
@SFrijters SFrijters mentioned this pull request Oct 13, 2018
Closed
@fpletz
Copy link
Member

fpletz commented Oct 13, 2018

@xeji Please don't merge automated updates without doing at least some checking. In particular, @r-ryantm does not check if dependent packages still build. I've had to fix NixOS modules in the past because arguments changed and the package bump was blindly merged. Furthermore, changelogs should also be read to check if this release fixes any security vulnerabilities that need to be backported etc.

@xeji
Copy link
Contributor

xeji commented Oct 13, 2018

@fpletz sorry about that. I appreciate your feedback and will try to be more careful in the future.

In this particular case I don't see what I should have done differently. ofborg said no other packages are affected (probably because it doesn't catch eval errors), so there was no indication this could break stuff.

@xeji
Copy link
Contributor

xeji commented Oct 13, 2018

reverted in ac6f485

xeji added a commit that referenced this pull request Oct 13, 2018
@xeji
Revert "vulkan-headers: 1.1.82.0 -> 1.1.85 (#47702)"
ac6f485 
This reverts commit e6b0646.

The bump broke vulkan-loader (eval error).
lukateras added a commit that referenced this pull request Oct 13, 2018
@lukateras
Revert "Revert "vulkan-headers: 1.1.82.0 -> 1.1.85 (#47702)""
45351e6 
This reverts commit ac6f485.
vulkan-loader bump: bae3fd3.
@r-ryantm r-ryantm deleted the auto-update/vulkan-headers branch October 13, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @GrahamcOfBorg @fpletz @xeji