Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectx: 0.5.1 -> 0.6.1 #47731

Merged
merged 1 commit into from Oct 3, 2018
Merged

kubectx: 0.5.1 -> 0.6.1 #47731

merged 1 commit into from Oct 3, 2018

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Oct 3, 2018

Also provides shell completions for zsh, bash and fish

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@periklis
kubectx: 0.5.1 -> 0.6.1
b9f9b05 
Also provides shell completions for zsh, bash and fish
@periklis
Copy link
Contributor Author

periklis commented Oct 3, 2018

cc @srhb

@srhb
Copy link
Contributor

srhb commented Oct 3, 2018

@GrahamcOfBorg build kubectx

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kubectx

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ya9zi56f5ff8y4w4c7glj7q6kpkipb66-kubectx
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ya9zi56f5ff8y4w4c7glj7q6kpkipb66-kubectx/bin
patching script interpreter paths in /nix/store/ya9zi56f5ff8y4w4c7glj7q6kpkipb66-kubectx
/nix/store/ya9zi56f5ff8y4w4c7glj7q6kpkipb66-kubectx/bin/.kubens-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/bash"
/nix/store/ya9zi56f5ff8y4w4c7glj7q6kpkipb66-kubectx/bin/.kubectx-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/ya9zi56f5ff8y4w4c7glj7q6kpkipb66-kubectx...
/nix/store/ya9zi56f5ff8y4w4c7glj7q6kpkipb66-kubectx

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubectx

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dvvipv43dypqrac4i57m0m7bv9857p42-kubectx
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dvvipv43dypqrac4i57m0m7bv9857p42-kubectx/bin
patching script interpreter paths in /nix/store/dvvipv43dypqrac4i57m0m7bv9857p42-kubectx
/nix/store/dvvipv43dypqrac4i57m0m7bv9857p42-kubectx/bin/.kubens-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
/nix/store/dvvipv43dypqrac4i57m0m7bv9857p42-kubectx/bin/.kubectx-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/dvvipv43dypqrac4i57m0m7bv9857p42-kubectx...
/nix/store/dvvipv43dypqrac4i57m0m7bv9857p42-kubectx

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: kubectx

Partial log (click to expand)

configuring
no configure script, doing nothing
installing
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7vdh1bvqbbfm6dk7l5m6l8i7hn75xnxx-kubectx/bin
patching script interpreter paths in /nix/store/7vdh1bvqbbfm6dk7l5m6l8i7hn75xnxx-kubectx
/nix/store/7vdh1bvqbbfm6dk7l5m6l8i7hn75xnxx-kubectx/bin/.kubectx-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/bash"
/nix/store/7vdh1bvqbbfm6dk7l5m6l8i7hn75xnxx-kubectx/bin/.kubens-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/bash"
/nix/store/7vdh1bvqbbfm6dk7l5m6l8i7hn75xnxx-kubectx

@srhb
Copy link
Contributor

srhb commented Oct 3, 2018

Do you know how I can test zsh completions? Tab-completing after installing it seems to do nothing, but perhaps I need to do something else.

@periklis
Copy link
Contributor Author

periklis commented Oct 3, 2018

@srhb I am used to configure that on macos with nix-darwin, but afaik this is what you need to do:
https://github.com/LnL7/nix-darwin/blob/master/modules/programs/zsh/default.nix#L183

@srhb
Copy link
Contributor

srhb commented Oct 3, 2018

Right, I have zsh completions working normally, I mean that they don't appear to do anything for kubectx. I'm just wondering if I need to change something with kubectl in order to get them to work. Did you test them yourself? If it works for you, that's fine too.

@periklis
Copy link
Contributor Author

periklis commented Oct 3, 2018

i've tested myself, but i have already a ~/.kube/config with some clusters listed.

@srhb
Copy link
Contributor

srhb commented Oct 3, 2018

OK, great!

@srhb srhb merged commit a8cbded into NixOS:master Oct 3, 2018
srhb pushed a commit that referenced this pull request Oct 3, 2018
@periklis @srhb
kubectx: 0.5.1 -> 0.6.1
f12ea61 
Also provides shell completions for zsh, bash and fish

(cherry picked from commit b9f9b05)
Backport of #47731
@periklis periklis deleted the update-kubectx branch October 3, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @srhb @GrahamcOfBorg