Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envsubst: init at 1.1.0 #47693

Merged
merged 1 commit into from Oct 5, 2018
Merged

envsubst: init at 1.1.0 #47693

merged 1 commit into from Oct 5, 2018

Conversation

nicknovitski
Copy link
Contributor

The envsubst command in the gettext package is missing a feature: sometimes, you want it to fail if the document refers to an unset variable, to detect certain typos and incorrect invocations. This tool is a go implementation of envsubst with that and a few other features.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@tomberek
Copy link
Contributor

tomberek commented Oct 3, 2018 •
edited

@GrahamcOfBorg build envsubst

(NixOS/ofborg#243)

@tomberek
Copy link
Contributor

tomberek commented Oct 3, 2018

Builds/runs locally on Ubuntu and NixOS.

@nlewo
Copy link
Member

nlewo commented Oct 5, 2018

@GrahamcOfBorg build envsubst

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: envsubst

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/hva0v0n9jjdimzaava0wc6p04qdh8xd3-envsubst-1.1.0-bin
shrinking /nix/store/hva0v0n9jjdimzaava0wc6p04qdh8xd3-envsubst-1.1.0-bin/bin/envsubst
cannot find section .dynamic
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hva0v0n9jjdimzaava0wc6p04qdh8xd3-envsubst-1.1.0-bin/bin
patching script interpreter paths in /nix/store/hva0v0n9jjdimzaava0wc6p04qdh8xd3-envsubst-1.1.0-bin
checking for references to /build in /nix/store/hva0v0n9jjdimzaava0wc6p04qdh8xd3-envsubst-1.1.0-bin...
cannot find section .dynamic
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
/nix/store/hva0v0n9jjdimzaava0wc6p04qdh8xd3-envsubst-1.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: envsubst

Partial log (click to expand)

find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
find: '/nix/store/j0qdj9zk6mxz7d2hz5d0dq6x7aygj5mr-envsubst-1.1.0': No such file or directory
/nix/store/j8qag8gq7aqb7h280y6imfks5jzbpw9i-envsubst-1.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: envsubst

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ymx2k3anxk8s46gbkgs4rk8r1fyx3iik-envsubst-1.1.0-bin
shrinking /nix/store/ymx2k3anxk8s46gbkgs4rk8r1fyx3iik-envsubst-1.1.0-bin/bin/envsubst
cannot find section .dynamic
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ymx2k3anxk8s46gbkgs4rk8r1fyx3iik-envsubst-1.1.0-bin/bin
patching script interpreter paths in /nix/store/ymx2k3anxk8s46gbkgs4rk8r1fyx3iik-envsubst-1.1.0-bin
checking for references to /build in /nix/store/ymx2k3anxk8s46gbkgs4rk8r1fyx3iik-envsubst-1.1.0-bin...
cannot find section .dynamic
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/ymx2k3anxk8s46gbkgs4rk8r1fyx3iik-envsubst-1.1.0-bin

@nlewo
Copy link
Member

nlewo commented Oct 5, 2018

Thanks

@nlewo nlewo merged commit 8c0d32f into NixOS:master Oct 5, 2018
@nicknovitski nicknovitski deleted the envsubst-init branch October 8, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicknovitski @tomberek @nlewo @GrahamcOfBorg