Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
base: 4ee7725d18a2^
Choose a base ref
...
head repository: opal/opal
compare: 3868d5e0aaeb
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Oct 2, 2018

  1. Only assign the block in Opal.send if it's given

    @elia
    elia committed Oct 2, 2018
    Copy the full SHA
    4ee7725 View commit details
    Browse the repository at this point in the history

  2. Improve String#to_proc perf by unrolling Opal.send 

    BEFORE

opal:elia/string-to-proc-perf ⤑ bundle exec rake bench:ips FILE=benchmark-ips/bm_symbol_to_proc.rb                                     ~/C/opal
=== Files: benchmark-ips/bm_symbol_to_proc.rb
bundle exec opal --dynamic-require ignore --missing-require ignore -ropal/platform -gbenchmark-ips -rbenchmark/ips -A benchmark-ips/bm_symbol_to_proc.rb
Warming up --------------------------------------
           map block     1.090k i/100ms
          map symbol   869.000  i/100ms
Calculating -------------------------------------
           map block     11.302k (± 1.0%) i/s -     56.680k in   5.015370s
          map symbol      8.878k (± 2.3%) i/s -     45.188k in   5.092622s

Comparison:
           map block:    11302.5 i/s
          map symbol:     8878.1 i/s - 1.27x  slower



AFTER

opal:master ⤑ bundle exec rake bench:ips FILE=benchmark-ips/bm_symbol_to_proc.rb                                                       ~/C/opal
=== Files: benchmark-ips/bm_symbol_to_proc.rb
bundle exec opal --dynamic-require ignore --missing-require ignore -ropal/platform -gbenchmark-ips -rbenchmark/ips -A benchmark-ips/bm_symbol_to_proc.rb
Warming up --------------------------------------
           map block   980.000  i/100ms
          map symbol   977.000  i/100ms
Calculating -------------------------------------
           map block     10.430k (± 1.1%) i/s -     52.920k in   5.074384s
          map symbol      9.804k (± 2.6%) i/s -     49.827k in   5.086232s

Comparison:
           map block:    10430.1 i/s
          map symbol:     9803.7 i/s - 1.06x  slower
    @elia
    elia committed Oct 2, 2018
    Copy the full SHA
    3868d5e View commit details
    Browse the repository at this point in the history