quaternion: 0.0.9.2 -> 0.0.9.3 #49318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefloweringash
changed the title
|
Sent this off without checking the It seems to be working. 👍 |
thefloweringash
changed the title
thefloweringash
force-pushed
the
quaternion-update
branch
from
ecb98b4
to
151cf7d
Compare
|
@GrahamcOfBorg build quaternion |
|
Success on x86_64-linux (full log) Attempted: quaternion Partial log (click to expand)
|
|
cc maintainer @peterhoeg |
|
Success on aarch64-linux (full log) Attempted: quaternion Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: quaternion Partial log (click to expand)
|
|
So this ran properly for you with libqmatrixclient 0.4.0? I kept getting segfaults. |
|
I saw some segfaults in my initial testing, but currently can't reproduce. Digging them out of Since it looks like a general Qt setup problem, I put it down to Qt being weird on NixOS. Keep in mind since it's a Qt package, it does have to be installed to work properly, if you don't, you get warnings about: |
|
My segfaults are entirely about making GLX go, are likely caused by X forwarding, and they disappear if I run with
What kind of segfaults were you seeing: on startup or during longer term use of the application? I haven't used it heavily, but it is able to send and receive messages. |
|
@thefloweringash, I just get an immediate segfault with and without
|
|
I don't suppose you could run quaternion under a debugger to extract a backtrace? I wrote a simple test case to be a middle-ground between our environments, which results in this screenshot: Test case:import ./make-test.nix ({ pkgs, ...} : {
name = "quaternion";
machine =
{ pkgs, ... }: {
imports = [ ./common/x11.nix ];
environment.systemPackages = [ pkgs.quaternion ];
};
testScript =
''
$machine->waitForX;
$machine->execute("quaternion &");
$machine->waitForWindow(qr/Login/);
$machine->sendKeys('esc'); # dismiss login window
# wait for focus to return to main window
$machine->sleep(5);
$machine->sendKeys('alt-h', 'a'); # open about screen
$machine->waitForWindow(qr/^About/);
$machine->sleep(1); # let the about screen render
$machine->screenshot("screen");
'';
}) |
|
@peterhoeg you could still try type |
|
Here you go: |
I actually did try that with the truncated coredump but it was useless. Running it under gdb as @thefloweringash suggested seems to be of more use. |
|
The main difference I see is that the dependencies as of this PR are: But your stack trace above includes: |
|
Are you using 18.09 or unstable? |
|
The machines I'm using to test this on are on 18.09. |
|
@peterhoeg it might have loaded the wrong qt from your nix profile. |
|
@peterhoeg Can you test this again, now that it's been a bit? I can't reproduce this segfault. I've built it locally(on unstable) and installed it with |
|
This currently fails to build on master https://hydra.nixos.org/build/85615374. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package update
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)