nim: 0.18.0 -> 0.19.0 #49250

royneary · 2018-10-27T12:22:54Z

remove sqlite as dependency (I don't see why it's needed)
run checkPhase after installPhase (at least one test assumes the
standard library in ../lib relative to the nim binary)
the broken tests pass now or don't exist anymore
two of the tests requiring network access pass now without network access
the tests in manyloc do not download dependencies and are passing now

Motivation for this change

Update nim to 0.19.0.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

- remove sqlite as dependency (I don't see why it's needed) - run checkPhase after installPhase (at least one test assumes the standard library in ../lib relative to the nim binary) - the broken tests pass now or don't exist anymore - two of the tests requiring network access pass now without network access - the tests in manyloc do not download dependencies and are passing now

disassembler · 2018-10-27T13:14:38Z

@GrahamcOfBorg build nim

GrahamcOfBorg · 2018-10-27T13:33:02Z

Failure on aarch64-linux (full log)

Attempted: nim

Partial log (click to expand)

PASS: cyclecollector C -d:release                                  (3.40048289 secs)
PASS: cyclecollector C -d:release -d:useRealtimeGC                 (3.43674994 secs)
PASS: cyclecollector C --gc:markAndSweep                           (2.61317205 secs)
PASS: cyclecollector C -d:release --gc:markAndSweep                (2.97520089 secs)
PASS: cyclecollector C --gc:boehm                                  (1.25764084 secs)
PASS: cyclecollector C -d:release --gc:boehm                       (0.91316295 secs)
/build/nim-0.19.0/tests/testament/tester html
tests failed
builder for '/nix/store/ci71mgmf37hb10k3pjyd5dblak95wy2i-nim-0.19.0.drv' failed with exit code 1
error: build of '/nix/store/ci71mgmf37hb10k3pjyd5dblak95wy2i-nim-0.19.0.drv' failed

GrahamcOfBorg · 2018-10-27T13:44:45Z

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nim

Partial log (click to expand)

  clang++ '-DV8_GYP_BUILD' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj/gen -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/j3cqsdyfdzv21kkgzwv19f7cxzz00znz-openssl-1.0.2p-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/.deps//private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-create-lowering.o.d.raw   -c -o /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-create-lowering.o ../deps/v8/src/compiler/js-create-lowering.cc
  clang++ '-DV8_GYP_BUILD' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj/gen -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/j3cqsdyfdzv21kkgzwv19f7cxzz00znz-openssl-1.0.2p-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/.deps//private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-generic-lowering.o.d.raw   -c -o /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-generic-lowering.o ../deps/v8/src/compiler/js-generic-lowering.cc
  clang++ '-DV8_GYP_BUILD' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj/gen -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/j3cqsdyfdzv21kkgzwv19f7cxzz00znz-openssl-1.0.2p-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/.deps//private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-graph.o.d.raw   -c -o /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-graph.o ../deps/v8/src/compiler/js-graph.cc
  clang++ '-DV8_GYP_BUILD' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj/gen -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/j3cqsdyfdzv21kkgzwv19f7cxzz00znz-openssl-1.0.2p-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/.deps//private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-inlining.o.d.raw   -c -o /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-inlining.o ../deps/v8/src/compiler/js-inlining.cc
  clang++ '-DV8_GYP_BUILD' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj/gen -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/j3cqsdyfdzv21kkgzwv19f7cxzz00znz-openssl-1.0.2p-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/.deps//private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-inlining-heuristic.o.d.raw   -c -o /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-inlining-heuristic.o ../deps/v8/src/compiler/js-inlining-heuristic.cc
  clang++ '-DV8_GYP_BUILD' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj/gen -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/j3cqsdyfdzv21kkgzwv19f7cxzz00znz-openssl-1.0.2p-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/.deps//private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-intrinsic-lowering.o.d.raw   -c -o /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-intrinsic-lowering.o ../deps/v8/src/compiler/js-intrinsic-lowering.cc
  clang++ '-DV8_GYP_BUILD' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj/gen -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/j3cqsdyfdzv21kkgzwv19f7cxzz00znz-openssl-1.0.2p-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/.deps//private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-native-context-specialization.o.d.raw   -c -o /private/tmp/nix-build-nodejs-slim-8.12.0.drv-0/node-v8.12.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/js-native-context-specialization.o ../deps/v8/src/compiler/js-native-context-specialization.cc
building of '/nix/store/gdcvliy19dcvcsrckg687jk1b82mhqq0-nodejs-slim-8.12.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/msxydnlij99p5m7k08ja42g846dbwjl0-nim-0.19.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/msxydnlij99p5m7k08ja42g846dbwjl0-nim-0.19.0.drv' failed

GrahamcOfBorg · 2018-10-27T14:02:36Z

Timed out, unknown build status on x86_64-linux (full log)

Attempted: nim

Partial log (click to expand)

PASS: cycleleak C -d:release --gc:markAndSweep                     (3.16289592 secs)
PASS: cycleleak C --gc:boehm                                       (1.32490492 secs)
PASS: cycleleak C -d:release --gc:boehm                            (1.19588614 secs)
PASS: closureleak C                                                (3.68987894 secs)
PASS: closureleak C -d:release                                     (3.80776811 secs)
PASS: closureleak C -d:release -d:useRealtimeGC                    (3.86992311 secs)
PASS: closureleak C --gc:markAndSweep                              (3.14992309 secs)
PASS: closureleak C -d:release --gc:markAndSweep                   (3.86592388 secs)
building of '/nix/store/n834y56z1brj3ml7npm1zpyfm71ijxcy-nim-0.19.0.drv' timed out after 1800 seconds
error: build of '/nix/store/n834y56z1brj3ml7npm1zpyfm71ijxcy-nim-0.19.0.drv' failed

royneary · 2018-10-27T18:48:31Z

I tried to fix the failure on Aarch64.
What can we do about the timeouts?

On x86_64 the tests were interrupted after 1800 seconds, I don't think they were hanging.
On darwin building nodejs took too long. I could try to disable nodejs for darwin, it's only needed for the tests that are not run anyway.

Mic92 · 2018-10-28T23:57:38Z

If ofborg timeouts this is ok. Our hydra has longer timeouts.

Mic92 · 2018-10-28T23:57:56Z

@GrahamcOfBorg build nim

GrahamcOfBorg · 2018-10-29T00:16:21Z

Success on aarch64-linux (full log)

Attempted: nim

Partial log (click to expand)

PASS: stackrefleak C -d:release --gc:boehm                         (1.88382483 secs)
PASS: cyclecollector C                                             (3.06635785 secs)
PASS: cyclecollector C -d:release                                  (3.41082907 secs)
PASS: cyclecollector C -d:release -d:useRealtimeGC                 (3.43448997 secs)
PASS: cyclecollector C --gc:markAndSweep                           (2.60068607 secs)
PASS: cyclecollector C -d:release --gc:markAndSweep                (2.96925998 secs)
PASS: cyclecollector C --gc:boehm                                  (1.24932003 secs)
PASS: cyclecollector C -d:release --gc:boehm                       (0.91260719 secs)
/build/nim-0.19.0/tests/testament/tester html
/nix/store/7nxv376k3ry7khwmrd5axy7mbn8nnnlg-nim-0.19.0

GrahamcOfBorg · 2018-10-29T00:25:08Z

Success on x86_64-darwin (full log)

Attempted: nim

Partial log (click to expand)

[Warning] No file found that matches: finish.exe
[Warning] No file found that matches: tools\start.bat
[Warning] No file found that matches: bin/makelink.exe
[Warning] No file found that matches: bin/7zG.exe
[Warning] No file found that matches: bin/*.dll
sh ./install.sh /nix/store/d0k8kpyydj1fdg08khcq4ipjlkzqqb6w-nim-0.19.0
Nim build detected
copying files...
installation successful
/nix/store/d0k8kpyydj1fdg08khcq4ipjlkzqqb6w-nim-0.19.0

GrahamcOfBorg · 2018-10-29T00:29:15Z

Timed out, unknown build status on x86_64-linux (full log)

Attempted: nim

Partial log (click to expand)

PASS: unicode.nim C                                                (3.06197500 secs)
PASS: unittest.nim C                                               (2.31589603 secs)
PASS: uri.nim C                                                    (2.17861605 secs)
PASS: volatile.nim C                                               (1.59678316 secs)
PASS: xmldom.nim C                                                 (1.88742185 secs)
PASS: xmldomparser.nim C                                           (2.13288188 secs)
PASS: xmlparser.nim C                                              (2.51197982 secs)
PASS: xmltree.nim C                                                (2.50686479 secs)
building of '/nix/store/838ldag9fs6p9lvsajhqm3vw8v1fz1ly-nim-0.19.0.drv' timed out after 1800 seconds
error: build of '/nix/store/838ldag9fs6p9lvsajhqm3vw8v1fz1ly-nim-0.19.0.drv' failed

c0bw3b · 2018-10-30T21:54:33Z

pkgs/development/compilers/nim/default.nix

@@ -30,10 +29,16 @@ stdenv.mkDerivation rec {

  buildInputs = [
    makeWrapper nodejs-slim-8_x tzdata coreutils


makeWrapper tzdata coreutils should be in nativeBuildInputs (they're needed only in installPhase and checkPhase)

c0bw3b · 2018-10-31T06:29:18Z

Build + tests successful on nixos-18.09 otherwise
Full log here

royneary · 2018-10-31T09:41:52Z

thanks for reviewing. I moved the packages you mentioned to nativeBuildInputs and nodejs-slim, too because it's only needed for the checkPhase.

Also I updated nodejs-slim-8_x to nodejs-slim-10_x.

gebner · 2018-10-31T10:18:12Z

@royneary You need to add the HOME=$TMPDIR fix to the other nim packages as well.

@GrahamcOfBorg build nrpl

(mosdepth doesn't seem to compile with the new version.)

GrahamcOfBorg · 2018-10-31T10:18:28Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nrpl

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-31T10:48:32Z

Timed out, unknown build status on x86_64-linux (full log)

Attempted: nrpl

Partial log (click to expand)

PASS: unittest.nim C                                               (2.39380908 secs)
PASS: uri.nim C                                                    (2.15112114 secs)
PASS: volatile.nim C                                               (1.61674714 secs)
PASS: xmldom.nim C                                                 (1.96292019 secs)
PASS: xmldomparser.nim C                                           (2.10824990 secs)
PASS: xmlparser.nim C                                              (2.68674994 secs)
PASS: xmltree.nim C                                                (2.47554517 secs)
building of '/nix/store/p48w1n52q5nl4xbs8frwa4ppxmxsnn20-nim-0.19.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/swd0ggw35z30miqx2qkhk2vbwri7gnbs-nrpl-20150522.drv': 1 dependencies couldn't be built
error: build of '/nix/store/swd0ggw35z30miqx2qkhk2vbwri7gnbs-nrpl-20150522.drv' failed

royneary · 2018-10-31T21:05:40Z

@gebner fixed.

gebner · 2018-11-02T09:20:09Z

nrpl builds for me now.

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 27, 2018

royneary added 2 commits October 27, 2018 16:58

nim: don't hardcode gcc

89d71c5

nim: disable test supposedly broken on Aarch64

651c178

roberth added the 8.has: package (update) label Oct 28, 2018

c0bw3b reviewed Oct 30, 2018

View reviewed changes

royneary added 2 commits October 31, 2018 10:37

nim: move build time dependencies into nativeBuildInputs

b786a47

nim: update nodejs-slim

9dcdf5a

royneary added 2 commits October 31, 2018 22:03

mosdeph: fix compilation with nim 0.19

bb2bae6

nrpl: fix compilation with nim 0.19

18aa80f

gebner merged commit 5de50f8 into NixOS:master Nov 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nim: 0.18.0 -> 0.19.0 #49250

nim: 0.18.0 -> 0.19.0 #49250

royneary commented Oct 27, 2018

disassembler commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

royneary commented Oct 27, 2018

Mic92 commented Oct 28, 2018

Mic92 commented Oct 28, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

c0bw3b Oct 30, 2018

c0bw3b commented Oct 31, 2018

royneary commented Oct 31, 2018

gebner commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

royneary commented Oct 31, 2018

gebner commented Nov 2, 2018

		@@ -30,10 +29,16 @@ stdenv.mkDerivation rec {

		buildInputs = [
		makeWrapper nodejs-slim-8_x tzdata coreutils

nim: 0.18.0 -> 0.19.0 #49250

nim: 0.18.0 -> 0.19.0 #49250

Conversation

royneary commented Oct 27, 2018

Motivation for this change

Things done

disassembler commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

GrahamcOfBorg commented Oct 27, 2018

royneary commented Oct 27, 2018

Mic92 commented Oct 28, 2018

Mic92 commented Oct 28, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

c0bw3b Oct 30, 2018

Choose a reason for hiding this comment

c0bw3b commented Oct 31, 2018

royneary commented Oct 31, 2018

gebner commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

royneary commented Oct 31, 2018

gebner commented Nov 2, 2018