Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: fix attrname, add sagemath alias #49248

Merged
merged 2 commits into from Oct 27, 2018
Merged

sage: fix attrname, add sagemath alias #49248

merged 2 commits into from Oct 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 27, 2018

Motivation for this change

Improve discoverability and repology report.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
sage: fix attrname
2513747 
This is a minimal change mainly to make sure repology recognizes this
package as sage. I plan a bit more refactoring later, but this is
intentionally kept minimally invasive so that it won't break anything
and can be backported to 18.09.
@timokau
sage: add sagemath alias
80833d1 
Sage is commonly referred to as sagemath (probably to improve
searchability). Many other distors call their package sagemath.
@timokau timokau mentioned this pull request Oct 27, 2018
Merged
9 tasks
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: sage

Partial log (click to expand)

    [15 tests, 0.14 s]
sage -t --long /nix/store/6xy4ap0vkgcziy6nalbsj4hdmzbf8z0h-sage-src-8.4/src/sage/modular/abvar/cuspidal_subgroup.py
    [66 tests, 0.86 s]
sage -t --long /nix/store/6xy4ap0vkgcziy6nalbsj4hdmzbf8z0h-sage-src-8.4/src/sage/modular/abvar/homology.py
    [95 tests, 1.01 s]
sage -t --long /nix/store/6xy4ap0vkgcziy6nalbsj4hdmzbf8z0h-sage-src-8.4/src/sage/modular/abvar/finite_subgroup.py
    [151 tests, 2.70 s]
building of '/nix/store/g4xgxwnikmr8zshbyrpfm5yxdj7lmg2s-sage-tests-8.4.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/ciqdwj7m7gv9adlpzdnx89wr31f408fx-sage-8.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ciqdwj7m7gv9adlpzdnx89wr31f408fx-sage-8.4.drv' failed

@timokau timokau merged commit f2b8262 into NixOS:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg