Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention new groups kvm and render in the release notes, fixes #49257 #49314

Merged
merged 1 commit into from Oct 30, 2018
Merged

Mention new groups kvm and render in the release notes, fixes #49257 #49314

merged 1 commit into from Oct 30, 2018

Conversation

typetetris
Copy link
Contributor

Motivation for this change

Fix #49257

by adding a bullet point to the release notes mentioning the addition of the groups kvm and render.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@typetetris typetetris changed the base branch from release-18.09 to master October 30, 2018 07:36
@typetetris typetetris changed the title 49257 Mention new groups kvm and render in the release notes, fixes #49257 Oct 30, 2018
@typetetris
Copy link
Contributor Author

Changed the target branch to master. The release in release-18.09 should be a subset of the release notes in master, so I have to add this to master first.

@typetetris
nixos/release-notes for 18.09: fix missing entry
30d2792 
 - the addition of the groups kvm and render breaks the configuration of
   users, which added them
@Mic92 Mic92 merged commit bb3cd00 into NixOS:master Oct 30, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 30, 2018

backport: 227cf39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@typetetris @Mic92 @GrahamcOfBorg