-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get nix-writers into nixpkgs #49290
get nix-writers into nixpkgs #49290
Conversation
8a31f01
to
0b614a1
Compare
I think something like this needs some good use cases to be included in full. Right now a lot of them seem like they have a pretty limited use case. I'd definitely be more comfortable with some getting included if it leads to less total code in Nixpkgs. I had a similar try at something like
So I think something like that is definitely useful. |
I think most of the use-cases would be outside of nixpkgs or in nixos modules. |
31a6ec2
to
713bf87
Compare
713bf87
to
aae4ceb
Compare
aae4ceb
to
070dcd7
Compare
What would be the recommended way to test these? use nixos-tests? |
070dcd7
to
b073f39
Compare
We have |
b073f39
to
bd1bad3
Compare
Soo I guess I'm done. I'm not sure about the tests though |
bd1bad3
to
2d02cd7
Compare
I think we need better criteria of where this can be used. Is this intended for internal use within Nixpkgs? If so, we need some usages inside the tree. If not, why not just release this as a separate repo? I just don't think we have a good enough use for this right now. Also, it critically doesn't support external files, which seems pretty important. You can kind of "fake" it with something like:
But this just reads the file and writes it back to the store twice! Anyway, this seems like something that is an interesting use of Nix, but should be left out of Nixpkgs. |
There are usecases inside of nixpkgs. Having something like services.xserver.windowManager.xmonad.config comes to my mind. I can implement this next. Also a lot of suckless software rely upon recompliation and there is no abstraction inside configuration.nix About the files ending up twice in the store, does writeScript(Bin) handle this? |
Get https://cgit.krebsco.de/nix-writers/about/ into nixpkgs
feedback is appreciated
stuff which still needs to be done:
nice to have: