Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wykurz to maintainers #49319

Merged
merged 1 commit into from Oct 28, 2018
Merged

Add wykurz to maintainers #49319

merged 1 commit into from Oct 28, 2018

Conversation

wykurz
Copy link
Contributor

@wykurz wykurz commented Oct 28, 2018

Motivation for this change

Add "wykurz" to maintainers. This change has been requested by @infinisil as feedback for #48765 to separate adding a new package (cpusets) with adding a new maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar merged commit 408e8ca into NixOS:master Oct 28, 2018
@wykurz wykurz deleted the add_maintainer branch October 12, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants