New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
easysnap: init at 2018-10-28 #49347
easysnap: init at 2018-10-28 #49347
Conversation
license = licenses.gpl3; | ||
maintainers = with maintainers; [ "sjau" ]; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this empty line.
@GrahamcOfBorg build easysnap |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: easysnap Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: easysnap Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: easysnap Partial log (click to expand)
|
Mostly LGTM, but the commits need some squashing to get rid of the nasty githubby commit messages. Should I do that? |
Whoops misclicked. |
What squashing? |
Is this going to be merged? |
@GrahamcOfBorg build easysnap |
Success on x86_64-linux (full log) Attempted: easysnap Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: easysnap Partial log (click to expand)
|
(non-blocking comment) seems like more reasonable for a personal overlay, since it is a small shell-script with the header of "HERE BE DRAGONS". However, since Nixpkgs doesn't have an inclusion / exclusion policy, it is (as noted) a non-blocking comment :) |
Thanks! |
Motivation for this change
Adding easysnap to nixpkgs/NixOS.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)