Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgcenter: init at 0.5.0 #49267

Merged
merged 1 commit into from Nov 26, 2018
Merged

pgcenter: init at 0.5.0 #49267

merged 1 commit into from Nov 26, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 27, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pgcenter

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jmg8j73faj8xrx3jnl65m8l48jcb4300-pgcenter-0.5.0-bin
shrinking /nix/store/jmg8j73faj8xrx3jnl65m8l48jcb4300-pgcenter-0.5.0-bin/bin/pgcenter-ef671b5
shrinking /nix/store/jmg8j73faj8xrx3jnl65m8l48jcb4300-pgcenter-0.5.0-bin/bin/pgcenter
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jmg8j73faj8xrx3jnl65m8l48jcb4300-pgcenter-0.5.0-bin/bin
patching script interpreter paths in /nix/store/jmg8j73faj8xrx3jnl65m8l48jcb4300-pgcenter-0.5.0-bin
checking for references to /build in /nix/store/jmg8j73faj8xrx3jnl65m8l48jcb4300-pgcenter-0.5.0-bin...
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
/nix/store/jmg8j73faj8xrx3jnl65m8l48jcb4300-pgcenter-0.5.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pgcenter

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bliwiqsmppkmbmlzaq79qmlc33pd5dwk-pgcenter-0.5.0-bin
shrinking /nix/store/bliwiqsmppkmbmlzaq79qmlc33pd5dwk-pgcenter-0.5.0-bin/bin/pgcenter-ef671b5
shrinking /nix/store/bliwiqsmppkmbmlzaq79qmlc33pd5dwk-pgcenter-0.5.0-bin/bin/pgcenter
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bliwiqsmppkmbmlzaq79qmlc33pd5dwk-pgcenter-0.5.0-bin/bin
patching script interpreter paths in /nix/store/bliwiqsmppkmbmlzaq79qmlc33pd5dwk-pgcenter-0.5.0-bin
checking for references to /build in /nix/store/bliwiqsmppkmbmlzaq79qmlc33pd5dwk-pgcenter-0.5.0-bin...
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
/nix/store/bliwiqsmppkmbmlzaq79qmlc33pd5dwk-pgcenter-0.5.0-bin

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pgcenter

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pgcenter

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xnh5lkpp7m20wrakdi5abm12qyw6jxa7-pgcenter-0.5.0-bin
shrinking /nix/store/xnh5lkpp7m20wrakdi5abm12qyw6jxa7-pgcenter-0.5.0-bin/bin/pgcenter
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xnh5lkpp7m20wrakdi5abm12qyw6jxa7-pgcenter-0.5.0-bin/bin
patching script interpreter paths in /nix/store/xnh5lkpp7m20wrakdi5abm12qyw6jxa7-pgcenter-0.5.0-bin
checking for references to /build in /nix/store/xnh5lkpp7m20wrakdi5abm12qyw6jxa7-pgcenter-0.5.0-bin...
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
/nix/store/xnh5lkpp7m20wrakdi5abm12qyw6jxa7-pgcenter-0.5.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pgcenter

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lxmk8iq7bxl8cjkyikmqfapi7xgfmajz-pgcenter-0.5.0-bin
shrinking /nix/store/lxmk8iq7bxl8cjkyikmqfapi7xgfmajz-pgcenter-0.5.0-bin/bin/pgcenter
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lxmk8iq7bxl8cjkyikmqfapi7xgfmajz-pgcenter-0.5.0-bin/bin
patching script interpreter paths in /nix/store/lxmk8iq7bxl8cjkyikmqfapi7xgfmajz-pgcenter-0.5.0-bin
checking for references to /build in /nix/store/lxmk8iq7bxl8cjkyikmqfapi7xgfmajz-pgcenter-0.5.0-bin...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
/nix/store/lxmk8iq7bxl8cjkyikmqfapi7xgfmajz-pgcenter-0.5.0-bin

worldofpeace
worldofpeace approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and executed locally without problems 👍

@worldofpeace worldofpeace merged commit 02114b5 into NixOS:master Nov 26, 2018
@marsam marsam deleted the feature/init-pgcenter branch November 26, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @GrahamcOfBorg @worldofpeace @samueldr