Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: fix "play" subcommand #49252

Merged
merged 1 commit into from Oct 28, 2018
Merged

crystal: fix "play" subcommand #49252

merged 1 commit into from Oct 28, 2018

Conversation

zarelit
Copy link
Member

@zarelit zarelit commented Oct 27, 2018

Co-authored-by: Merlin Göttlinger megoettlinger@gmail.com

Motivation for this change

Add dependencies needed by the Crystal web REPL

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zarelit @mgttlinger
crystal: fix "play" subcommand
473c890 
Co-authored-by: Merlin Göttlinger <megoettlinger@gmail.com>
@Mic92 Mic92 merged commit b770be4 into NixOS:master Oct 28, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 28, 2018

Is a backport required?

@zarelit
Copy link
Member Author

zarelit commented Oct 29, 2018

@Mic92 "play" is a really optional tool used to learn the language so it shouldn't affect the compiling. Users can point to https://play.crystal-lang.org in the meanwhile :-)

@Mic92
Copy link
Member

Mic92 commented Oct 29, 2018

@zarelit backports are easy to do. The question is, if this commit would also enable the command in nixos 18.09.

@zarelit zarelit mentioned this pull request Oct 29, 2018
Merged
9 tasks
@zarelit
Copy link
Member Author

zarelit commented Oct 29, 2018

@Mic92 the cherry-picking created conflicts so here is a new pull request for the backport. I never did one so plese let me know if it's the right workflow or not :-)

@Mic92
Copy link
Member

Mic92 commented Oct 30, 2018

@zarelit looks good to me.

@zarelit zarelit deleted the crystal_play branch June 25, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarelit @Mic92 @GrahamcOfBorg