Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbound: 1.8.0 -> 1.8.1 #49246

Merged
merged 1 commit into from Oct 29, 2018
Merged

unbound: 1.8.0 -> 1.8.1 #49246

merged 1 commit into from Oct 29, 2018

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Oct 27, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@disassembler
Copy link
Member

@GrahamcOfBorg build unbound

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: unbound

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/ax3lily131yjmzzgn5h4dv0ij3m302wl-unbound-1.8.1/lib  /nix/store/ax3lily131yjmzzgn5h4dv0ij3m302wl-unbound-1.8.1/bin
patching script interpreter paths in /nix/store/ax3lily131yjmzzgn5h4dv0ij3m302wl-unbound-1.8.1
/nix/store/ax3lily131yjmzzgn5h4dv0ij3m302wl-unbound-1.8.1/bin/unbound-control-setup: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qs3vlzbq63fxil5k8v9hzd58q3gg9d50-unbound-1.8.1-lib/lib
patching script interpreter paths in /nix/store/qs3vlzbq63fxil5k8v9hzd58q3gg9d50-unbound-1.8.1-lib
gzipping man pages under /nix/store/5y3h0abpx9wr4p9kv5g9aqqzs99m07x2-unbound-1.8.1-man/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/5y3h0abpx9wr4p9kv5g9aqqzs99m07x2-unbound-1.8.1-man
/nix/store/ax3lily131yjmzzgn5h4dv0ij3m302wl-unbound-1.8.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: unbound

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rkfaya399d8pi2n0myzzhpf3lrxl5f84-unbound-1.8.1-lib/lib
patching script interpreter paths in /nix/store/rkfaya399d8pi2n0myzzhpf3lrxl5f84-unbound-1.8.1-lib
checking for references to /build in /nix/store/rkfaya399d8pi2n0myzzhpf3lrxl5f84-unbound-1.8.1-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/ik4157l61f6c5xj28hrxkppc1vfb3lyr-unbound-1.8.1-man
gzipping man pages under /nix/store/ik4157l61f6c5xj28hrxkppc1vfb3lyr-unbound-1.8.1-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ik4157l61f6c5xj28hrxkppc1vfb3lyr-unbound-1.8.1-man
checking for references to /build in /nix/store/ik4157l61f6c5xj28hrxkppc1vfb3lyr-unbound-1.8.1-man...
/nix/store/8ihxhg47nn6dyi0d7zb4kj0608bfw077-unbound-1.8.1

@disassembler disassembler changed the base branch from master to staging October 27, 2018 13:22
@disassembler
Copy link
Member

@GrahamcOfBorg build unbound

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: unbound

Partial log (click to expand)

/nix/store/8ihxhg47nn6dyi0d7zb4kj0608bfw077-unbound-1.8.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: unbound

Partial log (click to expand)

cannot build derivation '/nix/store/58qgihiy7zyc501zvqlxvh4wx614j5w8-dns-root-data-2017-10-24.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/73b31rg30ayf6121c4gm8h5zci1pzshi-expat-2.2.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bca12rx7cnv613spajz5qqps27prbx5h-gnum4-1.4.18.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/f9m2lhqqbgc906xvf13a8fmbrfkyk241-hook.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bz79jzn6f3f4dgi8q7hklwpmjy19mwh8-perl-5.28.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/v46i39q881smsmvlyknjshv5n2yd3hm6-nettle-3.4.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/bf7512yl89ql16hwssjn12frm7vi6ij9-openssl-1.0.2p.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/96n4wd2589ddrgq5dy1pwm6qvws6656l-libevent-2.1.8.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/l4fgvqgv0nf46pbjh5r7kvm1andd5lwg-unbound-1.8.1.drv': 7 dependencies couldn't be built
error: build of '/nix/store/l4fgvqgv0nf46pbjh5r7kvm1andd5lwg-unbound-1.8.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: unbound

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k4m0cayw5g732zp4ylid6n0wq1xiyl2f-unbound-1.8.1-lib/lib
patching script interpreter paths in /nix/store/k4m0cayw5g732zp4ylid6n0wq1xiyl2f-unbound-1.8.1-lib
checking for references to /build in /nix/store/k4m0cayw5g732zp4ylid6n0wq1xiyl2f-unbound-1.8.1-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/7867z5lq7cpc2jdmfp8xbbh982sshf1l-unbound-1.8.1-man
gzipping man pages under /nix/store/7867z5lq7cpc2jdmfp8xbbh982sshf1l-unbound-1.8.1-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7867z5lq7cpc2jdmfp8xbbh982sshf1l-unbound-1.8.1-man
checking for references to /build in /nix/store/7867z5lq7cpc2jdmfp8xbbh982sshf1l-unbound-1.8.1-man...
/nix/store/mdprb6mvc8jwrj4s3dva4y7crb2yzwxw-unbound-1.8.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: unbound

Partial log (click to expand)

/nix/store/mdprb6mvc8jwrj4s3dva4y7crb2yzwxw-unbound-1.8.1

@joachifm joachifm mentioned this pull request Oct 27, 2018
Closed
9 tasks
vcunat
vcunat approved these changes Oct 27, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat
Copy link
Member

vcunat commented Oct 27, 2018 •
edited

I'd wait a while to give maintainers a chance to react: @fpletz, @fadenb.

@vcunat
Copy link
Member

vcunat commented Oct 27, 2018

Oh, @ehmry is the second one.

@Mic92 Mic92 merged commit 6bad623 into NixOS:staging Oct 29, 2018
@vcunat
Copy link
Member

vcunat commented Oct 31, 2018

BTW, "you" might be interested in switching unbound's openssl to 1.1.x, e.g. because of TLS forwarding. Well, unless we switch the default soon.

@fadenb fadenb deleted the unbount_1.8.1 branch November 1, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fadenb @disassembler @GrahamcOfBorg @vcunat @Mic92 @roberth