Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tbb: 2018_U5 -> 2018_U6 #49245

Closed
wants to merge 1 commit into from
Closed

tbb: 2018_U5 -> 2018_U6 #49245

wants to merge 1 commit into from

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Oct 27, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

There is already 2019_U1 out.

@markuskowa
Copy link
Member

@GrahamcOfBorg build tbb

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tbb

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6
shrinking /nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6/lib/libtbbmalloc_proxy.so.2
shrinking /nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6/lib/libtbbmalloc.so.2
shrinking /nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6/lib/libtbb.so.2
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6/lib
patching script interpreter paths in /nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6
checking for references to /build in /nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6...
/nix/store/42pd66aqc40w80j6vrxvd4vfis2qsj03-tbb-2018_U6

@fadenb
Copy link
Contributor Author

fadenb commented Oct 27, 2018

@markuskowa The GitHub releases page ( https://github.com/01org/tbb/releases ) lists 2018_U6 as "latest release".
I do not know that package very well, should I package the 2019_U1 instead?

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tbb

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6
shrinking /nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6/lib/libtbb.so.2
shrinking /nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6/lib/libtbbmalloc_proxy.so.2
shrinking /nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6/lib/libtbbmalloc.so.2
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6/lib
patching script interpreter paths in /nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6
checking for references to /build in /nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6...
/nix/store/r9xd6cj1sf59iab2m6d1vrkc16j45fgj-tbb-2018_U6

@markuskowa
Copy link
Member

I would give 2019_U1 a try. I was not listed as unstable on the homepage. We just need to check if all packages that depend on tbb still compile.

@markuskowa
Copy link
Member

2019_U2 is now marked as latest release. We should use that one.

markuskowa
markuskowa requested changes Nov 14, 2018
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 2019_U2

@markuskowa
Copy link
Member

2019_U3 is already out. Closing this PR so that the auto updater can pick it up in the next run.

@markuskowa markuskowa closed this Jan 10, 2019
@fadenb fadenb deleted the tbb_2018U6 branch March 2, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa requested changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fadenb @markuskowa @GrahamcOfBorg @roberth