Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openjpeg Patching CVE-2018-7648 #49262

Closed
wants to merge 1 commit into from
Closed

Openjpeg Patching CVE-2018-7648 #49262

wants to merge 1 commit into from

Conversation

stammon
Copy link
Contributor

@stammon stammon commented Oct 27, 2018

Motivation for this change
Things done
  • Adding a patch to Openjpeg
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@stammon stammon mentioned this pull request Oct 27, 2018
Closed
85 tasks
@adisbladis
Copy link
Member

@GrahamcOfBorg build openjpeg

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openjpeg

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8cjsz0sddbpym0lif6bxs1k31sr8yn6n-openjpeg-2.3.0/lib  /nix/store/8cjsz0sddbpym0lif6bxs1k31sr8yn6n-openjpeg-2.3.0/bin
patching script interpreter paths in /nix/store/8cjsz0sddbpym0lif6bxs1k31sr8yn6n-openjpeg-2.3.0
checking for references to /build in /nix/store/8cjsz0sddbpym0lif6bxs1k31sr8yn6n-openjpeg-2.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/0hgy6qqkjml78l5n7q6wszan4z731r80-openjpeg-2.3.0-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0hgy6qqkjml78l5n7q6wszan4z731r80-openjpeg-2.3.0-dev/lib
patching script interpreter paths in /nix/store/0hgy6qqkjml78l5n7q6wszan4z731r80-openjpeg-2.3.0-dev
checking for references to /build in /nix/store/0hgy6qqkjml78l5n7q6wszan4z731r80-openjpeg-2.3.0-dev...
/nix/store/8cjsz0sddbpym0lif6bxs1k31sr8yn6n-openjpeg-2.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: openjpeg

Partial log (click to expand)

Patching '/nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev/lib/pkgconfig/libopenjp2.pc' includedir to output /nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev
Patching '/nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev/lib/pkgconfig/libopenjp3d.pc' includedir to output /nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev
Patching '/nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev/lib/pkgconfig/libopenjpwl.pc' includedir to output /nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/avf6a1cvksl0paf6dkn6kx4r372wqpwi-openjpeg-2.3.0/lib  /nix/store/avf6a1cvksl0paf6dkn6kx4r372wqpwi-openjpeg-2.3.0/bin
patching script interpreter paths in /nix/store/avf6a1cvksl0paf6dkn6kx4r372wqpwi-openjpeg-2.3.0
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev/lib
patching script interpreter paths in /nix/store/byd5h2wsxi007gdrq9nilmzkfy9jlvfk-openjpeg-2.3.0-dev
/nix/store/avf6a1cvksl0paf6dkn6kx4r372wqpwi-openjpeg-2.3.0

@adisbladis
Copy link
Member

Please change your commit message according to https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openjpeg

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kdxjib64m6g4sgd0hwg36gh9par6lhmy-openjpeg-2.3.0/lib  /nix/store/kdxjib64m6g4sgd0hwg36gh9par6lhmy-openjpeg-2.3.0/bin
patching script interpreter paths in /nix/store/kdxjib64m6g4sgd0hwg36gh9par6lhmy-openjpeg-2.3.0
checking for references to /build in /nix/store/kdxjib64m6g4sgd0hwg36gh9par6lhmy-openjpeg-2.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/g57yijqrpv2lwq6qgrp9a2fiqip5593v-openjpeg-2.3.0-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g57yijqrpv2lwq6qgrp9a2fiqip5593v-openjpeg-2.3.0-dev/lib
patching script interpreter paths in /nix/store/g57yijqrpv2lwq6qgrp9a2fiqip5593v-openjpeg-2.3.0-dev
checking for references to /build in /nix/store/g57yijqrpv2lwq6qgrp9a2fiqip5593v-openjpeg-2.3.0-dev...
/nix/store/kdxjib64m6g4sgd0hwg36gh9par6lhmy-openjpeg-2.3.0

@adisbladis
Copy link
Member

Also: please direct this to staging

@c0bw3b c0bw3b mentioned this pull request Oct 31, 2018
Merged
9 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2018

Closing in favor of #49542

@c0bw3b c0bw3b closed this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stammon @adisbladis @GrahamcOfBorg @c0bw3b @Janik-Haag