Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splix: add missing printer models #49266

Closed
wants to merge 2 commits into from
Closed

splix: add missing printer models #49266

wants to merge 2 commits into from

Conversation

zarelit
Copy link
Member

@zarelit zarelit commented Oct 27, 2018 •
edited

Add support for ML-2160 ML-2165 ML-3310 ML-3310ND.
The PPD files were not picked up by the Makefile because they were
in the wrong directory of the original source.

Co-authored-by: Merlin Göttlinger megoettlinger@gmail.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zarelit @mgttlinger
splix: add missing printer models
20d7e95 
Add support for ML-2160 ML-2165 ML-3310 ML-3310ND.
The PPD files were not picked up by the Makefile because they were
in the wrong directory of the original source.

Co-authored-by: Merlin Göttlinger <megoettlinger@gmail.com>
@zarelit zarelit mentioned this pull request Oct 27, 2018
Open
@peti
Prefer mv for clarity
354cfab 
It feels like a good idea to avoid having pppd files in multiple locations.
peti
peti approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change makes my printer work with Splix! Thank you very much.

@peti
Copy link
Member

peti commented Oct 29, 2018

Merged in b4c7ff5.

@peti peti closed this Oct 29, 2018
@zarelit zarelit deleted the splix_missing_printers branch June 25, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarelit @peti @GrahamcOfBorg