Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppclean: init at 2018-05-12 #49264

Merged
merged 5 commits into from Oct 30, 2018
Merged

cppclean: init at 2018-05-12 #49264

merged 5 commits into from Oct 30, 2018

Conversation

nthorne
Copy link
Contributor

@nthorne nthorne commented Oct 27, 2018

Motivation for this change

To introduce the C++ linter cppclean.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b reviewed Oct 27, 2018
View reviewed changes
pkgs/development/tools/cppclean/default.nix Outdated
meta = with stdenv.lib; {
description = "Finds problems in C++ source that slow development of large code bases";
homepage = https://github.com/myint/cppclean;
license = "Apache-2.0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license = licenses.asl20;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There it was; thanks, @c0bw3b!

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 30, 2018

@GrahamcOfBorg build cppclean

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cppclean

Partial log (click to expand)

+ ./cppclean test/c++11.h
+ ./cppclean test/init_lists.h
+ rm -f .tmp
+ ./cppclean --include-path=test/external --exclude=ignore.cc test
+ tr '\\' /
+ diff --unified test/expected.txt .tmp
+ rm -f .tmp
+ echo -e '\x1b[01;32mOkay\x1b[0m'
Okay
/nix/store/z5j67hxxqxl2ll046q1rksh82fbpvil8-cppclean-2018-05-12

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cppclean

Partial log (click to expand)

+ ./cppclean test/c++11.h
+ ./cppclean test/init_lists.h
+ rm -f .tmp
+ tr '\\' /
+ ./cppclean --include-path=test/external --exclude=ignore.cc test
+ diff --unified test/expected.txt .tmp
+ rm -f .tmp
+ echo -e '\x1b[01;32mOkay\x1b[0m'
Okay
/nix/store/6bmcgigdqhwwqng2g24cmhvf10vc3caz-cppclean-2018-05-12

c0bw3b
c0bw3b reviewed Oct 30, 2018
View reviewed changes
pkgs/development/tools/cppclean/default.nix Outdated
with python3Packages;

buildPythonApplication rec {
name = "cppclean-${version}";
Copy link
Contributor

@c0bw3b c0bw3b Oct 30, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed it the first time, but since we are fetching a non-release commit, guidelines would recommend:

  name = "cppclean-unstable-${version}";
  version = "2018-05-12";

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 30, 2018

@GrahamcOfBorg build cppclean

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cppclean

Partial log (click to expand)

+ ./cppclean test/c++11.h
+ ./cppclean test/init_lists.h
+ rm -f .tmp
+ ./cppclean --include-path=test/external --exclude=ignore.cc test
+ tr '\\' /
+ diff --unified test/expected.txt .tmp
+ rm -f .tmp
+ echo -e '\x1b[01;32mOkay\x1b[0m'
Okay
/nix/store/6wfsfdf4d5y0q4b8r65cy74lc16acfwv-cppclean-unstable-2018-05-12

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cppclean

Partial log (click to expand)

+ ./cppclean test/c++11.h
+ ./cppclean test/init_lists.h
+ rm -f .tmp
+ ./cppclean --include-path=test/external --exclude=ignore.cc test
+ tr '\\' /
+ diff --unified test/expected.txt .tmp
+ rm -f .tmp
+ echo -e '\x1b[01;32mOkay\x1b[0m'
Okay
/nix/store/z3nvva99x2aid7r8m5ildvhd9kr5s0sx-cppclean-unstable-2018-05-12

@c0bw3b c0bw3b merged commit d48cef7 into NixOS:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nthorne @c0bw3b @GrahamcOfBorg