Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binutils: 2.30 -> 2.31.1 #49324

Closed
wants to merge 2 commits into from
Closed

binutils: 2.30 -> 2.31.1 #49324

wants to merge 2 commits into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 28, 2018 •
edited

Motivation for this change
Things done

Tested transitively by running a few select nixos tests (postgresql, openssh, installer) on x86_64-linux.
aarch64 not yet tested.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Ericson2314 @ckauhaus

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: binutils

Partial log (click to expand)

cannot build derivation '/nix/store/r726swq4907jv2sndy1fc66d4szdc0wn-swift-corefoundation.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/52w72f2d6fsc0b0vm69js65asiq73q5a-bootstrap-stage4-stdenv-darwin.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/c8rxpzj02l2y3d62b5ys74kj847apjf3-bootstrap-stage4-stdenv-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/d0pj01lg46hsijj6dzfk5kf97p8sbzyg-expand-response-params.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/93prc5akyq45l4c63nh7pjhwi0b36s1r-gnum4-1.4.18.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/j57s972ghn1x01mxaqljc1lrbkxk3cxp-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/w7nknmbh5vz3wd89jqycxy3cmpi8gqfj-bison-3.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0mgz18ramnx3r84sbw08mrspyjcmp7nl-binutils-2.31.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/8wscyc8x146xan1dh7zhpf506mxfnrxn-binutils-wrapper-2.31.1.drv': 6 dependencies couldn't be built
error: build of '/nix/store/8wscyc8x146xan1dh7zhpf506mxfnrxn-binutils-wrapper-2.31.1.drv' failed

@vcunat
Copy link
Member

vcunat commented Oct 28, 2018

/cc #47128
Some CVEs are apparently fixed, but I haven't looked how severe they are.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: binutils

Partial log (click to expand)

patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xd2q4j6hg9p4s9yh86x7rw26pd3gwlf9-binutils-wrapper-2.31.1
checking for references to /build in /nix/store/xd2q4j6hg9p4s9yh86x7rw26pd3gwlf9-binutils-wrapper-2.31.1...
Using dynamic linker: '/nix/store/awhfcndqi51508kgbzr5wr08j2bgnxn1-glibc-2.27/lib/ld-linux-aarch64.so.1'
/nix/store/xd2q4j6hg9p4s9yh86x7rw26pd3gwlf9-binutils-wrapper-2.31.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: binutils

Partial log (click to expand)

cannot build derivation '/nix/store/xj65ddn4wvyafiqdgmn7iflhh96g1hap-attr-2.4.47.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v22ps5mpdirm2ny69m0spb5qa881y4vh-bash-4.4-p23.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/v2rd4xp1a34sdrvq1hjqsqsxr7fbqzig-binutils-2.31.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zmgbiqqisqpqii6z9y57i06hxi8z4jm2-pcre-8.42.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m0hs71w1n14a8ipl06r596zc556fj5si-xz-5.2.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/l4amaxb657zfi4vxw4pbb9bcjqrzgrzy-acl-2.2.52.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zwcir26iw8jfk58q288g4a18p8q8jg43-gnugrep-3.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ip4jqn09vpyxyc1khd4qgfiysj8hrypy-coreutils-8.30.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/awbs9v7cgs2s5csiww4w804ghn1y47n4-binutils-wrapper-2.31.1.drv': 4 dependencies couldn't be built
error: build of '/nix/store/awbs9v7cgs2s5csiww4w804ghn1y47n4-binutils-wrapper-2.31.1.drv' failed

@ckauhaus
Copy link
Contributor

Some CVEs are apparently fixed, but I haven't looked how severe they are.

See #47122, #47121, #42882, #41748, #40765, and #38993 for candidates. Needs to be reviewed.

@guaraqe guaraqe mentioned this pull request Dec 5, 2018
Closed
6 tasks
@NeQuissimus
Copy link
Member

NeQuissimus commented Dec 10, 2018 •
edited

@adisbladis Can you rebase this, please?
I would like this and #51770 to be merged :)

This was referenced Jan 12, 2019
Closed
Closed
@dtzWill
Copy link
Member

dtzWill commented Jan 18, 2019

Ping! :)

@ThomasMader
Copy link
Contributor

binutils 2.32 is out.

@NeQuissimus
Copy link
Member

NeQuissimus commented Jan 20, 2019 •
edited

There is a 2.32 branch but I see no such tag or release in https://ftp.gnu.org/gnu/binutils/

I am going to rebase this and push into staging

@NeQuissimus
Copy link
Member

53e1db9

@ckauhaus ckauhaus mentioned this pull request Mar 9, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@adisbladis @GrahamcOfBorg @vcunat @ckauhaus @NeQuissimus @dtzWill @ThomasMader @veprbl