Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] installation-device: set GC initial heap size to 1MB #49328

Merged
merged 1 commit into from Nov 6, 2018
Merged

[18.09] installation-device: set GC initial heap size to 1MB #49328

merged 1 commit into from Nov 6, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 28, 2018 •
edited

Motivation for this change

100000 (100kB) is too aggressive (too low) and gets ignored by the GC after raising warnings
Fixes #43339

Backport of #49326
/cc @samueldr as release manager

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I had the same warning as in #43339 on a demo VM.
After doing export GC_INITIAL_HEAP_SIZE=1M I could use nix-channel --update or nixos-rebuild switch without any GC warnings.

@c0bw3b
installation-device: set GC initial heap size to 1MB
09740d8 
100000 (100kB) is too aggressive (too low) and gets ignored by the GC
Fixes NixOS#43339
@markuskowa
Copy link
Member

@GrahamcOfBorg test installer

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.installer

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.installer

No partial log is available.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 30, 2018

cc @edolstra here too, for backporting and solving issue #43339 that users encounter with 18.09 install media

@samueldr samueldr merged commit 6d6e4e6 into NixOS:release-18.09 Nov 6, 2018
@c0bw3b c0bw3b deleted the nixos/gc-release branch November 6, 2018 18:09
@c0bw3b c0bw3b mentioned this pull request Dec 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@c0bw3b @markuskowa @GrahamcOfBorg @roberth @samueldr