Skip to content

pythonPackages.networkx: 2.1 -> 2.2 #49280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2018
Merged

pythonPackages.networkx: 2.1 -> 2.2 #49280

merged 2 commits into from
Nov 7, 2018
+31 −3

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 27, 2018 •
edited
Loading

Motivation for this change

A new networkx version is out and needs sage fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@timokau timokau requested a review from FRidh as a code owner October 27, 2018 16:19
@timokau
Copy link
Member Author

timokau commented Oct 27, 2018

@GrahamcOfBorg build python2Packages.networkx python3Packages.networkx

@FRidh I'm unclear on the policy of python upgrades. Can I just merge them or do you collect them and upgrade all at once or...?

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.networkx, python3Packages.networkx

Partial log (click to expand)

networkx.tests.test_relabel.TestRelabel.test_relabel_nodes_multidigraph ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_nodes_multigraph ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_nodes_orderedgraph ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_selfloop ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_toposort ... ok

----------------------------------------------------------------------
Ran 3219 tests in 181.284s

OK (skipped=61)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.networkx, python3Packages.networkx

Partial log (click to expand)

networkx.tests.test_relabel.TestRelabel.test_relabel_nodes_multidigraph ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_nodes_multigraph ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_nodes_orderedgraph ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_selfloop ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_toposort ... ok

----------------------------------------------------------------------
Ran 3219 tests in 223.151s

OK (skipped=61)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.networkx, python3Packages.networkx

Partial log (click to expand)

networkx.tests.test_relabel.TestRelabel.test_relabel_nodes_orderedgraph ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_selfloop ... ok
networkx.tests.test_relabel.TestRelabel.test_relabel_toposort ... ok

----------------------------------------------------------------------
Ran 3219 tests in 568.499s

OK (skipped=61)
/nix/store/8gy8g9ii95wl113kj74p5khdl44qz8bk-python2.7-networkx-2.2
/nix/store/p6wyhn0dk41g6r1kfx52jzi8mqk6irzl-python3.6-networkx-2.2

@roberth roberth added the 8.has: package (update) This PR updates a package to a newer version label Oct 28, 2018
@FRidh FRidh self-assigned this Oct 28, 2018
FRidh
FRidh reviewed Oct 28, 2018
View reviewed changes
pkgs/development/python-modules/networkx/default.nix
@@ -7,12 +7,13 @@

buildPythonPackage rec {
pname = "networkx";
version = "2.1";
# upgrade may break sage, please test the sage build or ping @timokau on upgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a lot of packages that can break sage so I don't see much value in this comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are not that many that regularly break sage. And even if there are: I have to fix it after the upgrade anyways. Easier for everybody if it is tested and/or I get notified before the breakage happens.

@timokau
Copy link
Member Author

timokau commented Oct 28, 2018

@GrahamcOfBorg eval

@timokau
sage: add fetchSageDiff utility function

Verified

This commit was signed with the committer’s verified signature.
mkg20001 Maciej Krüger
GPG key ID: 0D948CE19CF49C5F
Verified
Learn about vigilant mode
f7d64c5
@timokau
pythonPackages.networkx: 2.1 -> 2.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
44f9370
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: sage

Partial log (click to expand)

build/cythonized/sage/libs/ntl/ntlwrap_impl.h:41:13: warning: 'void mpz_to_ZZ(NTL::ZZ*, mpz_srcptr)' defined but not used [-Wunused-function]
 static void mpz_to_ZZ(struct ZZ* output, mpz_srcptr x)
             ^~~~~~~~~
building of '/nix/store/s70di4v1zsis8dkc8akbcjc1bzgvq6s8-python2.7-sagelib-8.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/vjqgzbgxdi4ck97k4rm66vyr8r6jwf83-python-2.7.15-env.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fl9byib0ffmlxgqmmfw0zs69lmbx5l3s-sage-env.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/1ql5m11s4q7ak5kh0aj3rj6dlhk3f1nh-sage-with-env-8.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/k37zwr5bkqv791xiran0raic7k8ja0hq-sage-tests-8.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/myy36fm99wlj5zpaxgbcfn934g0xjb9v-sage-8.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/myy36fm99wlj5zpaxgbcfn934g0xjb9v-sage-8.4.drv' failed

@timokau
Copy link
Member Author

timokau commented Nov 7, 2018

@FRidh ping :)

@FRidh FRidh merged commit efe6322 into NixOS:master Nov 7, 2018
@timokau timokau deleted the networkx-2.2 branch November 7, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @GrahamcOfBorg @FRidh @roberth