Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mozart2: init at 2.0.1 #49272

Merged
merged 1 commit into from Sep 23, 2019
Merged

mozart2: init at 2.0.1 #49272

merged 1 commit into from Sep 23, 2019

Conversation

layus
Copy link
Member

@layus layus commented Oct 27, 2018

Adding this non-binary version besides the existing mozart-binary.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2018

There is no need for adding a "2" in the names and for the aliases IMHO.
Sticking to mozart and mozart-binary is fine and clear.

@layus
Copy link
Member Author

layus commented Nov 3, 2018

There is no need for adding a "2" in the names and for the aliases IMHO.
Sticking to mozart and mozart-binary is fine and clear.

Well, I am not too sure about that. the upstream repo is at mozart/mozart2, implying that this is a different project. ArchLinux and debian also use mozart2 as the package name.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2018

You're right, upstream name is mozart2 so we should stick to it.

It feels somewhat weird to have 3 names for the previous v2.0.0-binary package and 1 for the newer v2.0.1 built from source. I'm not sure we should continue to carry the binary pkg after this get merged but that is probably a job for another PR later.

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

Are there any updates on this pull request, please?

@layus
Copy link
Member Author

layus commented Aug 12, 2019

Updated, rebased and fixed ! I guess this can be merged when Ofborg accepts ;-)

@layus
Copy link
Member Author

layus commented Aug 13, 2019

Turns out using pname was a bad idea ;-), there was still one reference to it 🤦‍♂️

@joachifm
Copy link
Contributor

@GrahamcOfBorg build mozart2

@joachifm
Copy link
Contributor

This needs to be rebased. Is the darwin failure reported by ofborg a regression?

@layus
Copy link
Member Author

layus commented Sep 23, 2019

@joachifm Thanks, this has been rebased, and updated to fix the OS/X failure. I do not have access to any darwin builder, so this is a blind guess.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build mozart2

@joachifm joachifm merged commit 5b387aa into NixOS:master Sep 23, 2019
@joachifm
Copy link
Contributor

I think we can have a look at the darwin thing later. Thank you.

@layus layus deleted the add-mozart branch October 2, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants