Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reason: 3.3.3 -> 3.3.7 #49325

Merged
merged 2 commits into from Oct 28, 2018
Merged

reason: 3.3.3 -> 3.3.7 #49325

merged 2 commits into from Oct 28, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 28, 2018

Motivation for this change

Update. Compatibility with recent menhir.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7/bin/refmt
shrinking /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/reason.cmxs
shrinking /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/easy_format/reason.easy_format.cmxs
shrinking /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/rtop/rtop.cmxs
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7/lib  /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7/bin
patching script interpreter paths in /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7
/nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/hwf2kgm1ad03dibzxc7ym5dvfjysvp7h-ocaml-4.06.1/bin/ocaml"
checking for references to /build in /nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7...
/nix/store/ax0yc8g8zc54bd3qrh66l6b6liqs88q7-ocaml4.06.1-reason-3.3.7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reason

Partial log (click to expand)

installing
Processing file reason.install as reason.
Processing file rtop.install as rtop.
post-installation fixup
moving /nix/store/gw7rvx6y9xbvxviqgqgy2jh9agl742q3-ocaml4.06.1-reason-3.3.7/doc to /nix/store/gw7rvx6y9xbvxviqgqgy2jh9agl742q3-ocaml4.06.1-reason-3.3.7/share/doc
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gw7rvx6y9xbvxviqgqgy2jh9agl742q3-ocaml4.06.1-reason-3.3.7/lib  /nix/store/gw7rvx6y9xbvxviqgqgy2jh9agl742q3-ocaml4.06.1-reason-3.3.7/bin
patching script interpreter paths in /nix/store/gw7rvx6y9xbvxviqgqgy2jh9agl742q3-ocaml4.06.1-reason-3.3.7
/nix/store/gw7rvx6y9xbvxviqgqgy2jh9agl742q3-ocaml4.06.1-reason-3.3.7/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/bnnim7p5y62yfmbqna7hh0x3prl38x51-ocaml-4.06.1/bin/ocaml"
/nix/store/gw7rvx6y9xbvxviqgqgy2jh9agl742q3-ocaml4.06.1-reason-3.3.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7/bin/ocamlmerlin-reason
shrinking /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/rtop/rtop.cmxs
shrinking /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/reason.cmxs
shrinking /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/easy_format/reason.easy_format.cmxs
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7/lib  /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7/bin
patching script interpreter paths in /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7
/nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/69z8hbbba1w59nbcylfglsh4lvb9fnc5-ocaml-4.06.1/bin/ocaml"
checking for references to /build in /nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7...
/nix/store/hgrbkd9n70xmxgyn19hqr5b3qj1r863v-ocaml4.06.1-reason-3.3.7

@c0bw3b
reason: makeWrapper needed at build time only
195ecd9 
moved makeWrapper from buildInputs to nativeBuildInputs
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7/bin/refmt
shrinking /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/reason.cmxs
shrinking /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/easy_format/reason.easy_format.cmxs
shrinking /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/rtop/rtop.cmxs
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7/lib  /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7/bin
patching script interpreter paths in /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7
/nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/hwf2kgm1ad03dibzxc7ym5dvfjysvp7h-ocaml-4.06.1/bin/ocaml"
checking for references to /build in /nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7...
/nix/store/mm3a5y3bdpa3kpmk8h4xzbgg9cmgccjd-ocaml4.06.1-reason-3.3.7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reason

Partial log (click to expand)

installing
Processing file reason.install as reason.
Processing file rtop.install as rtop.
post-installation fixup
moving /nix/store/i8p47jwflgj1xzfid19yaalfkrqx4il3-ocaml4.06.1-reason-3.3.7/doc to /nix/store/i8p47jwflgj1xzfid19yaalfkrqx4il3-ocaml4.06.1-reason-3.3.7/share/doc
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/i8p47jwflgj1xzfid19yaalfkrqx4il3-ocaml4.06.1-reason-3.3.7/lib  /nix/store/i8p47jwflgj1xzfid19yaalfkrqx4il3-ocaml4.06.1-reason-3.3.7/bin
patching script interpreter paths in /nix/store/i8p47jwflgj1xzfid19yaalfkrqx4il3-ocaml4.06.1-reason-3.3.7
/nix/store/i8p47jwflgj1xzfid19yaalfkrqx4il3-ocaml4.06.1-reason-3.3.7/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/bnnim7p5y62yfmbqna7hh0x3prl38x51-ocaml-4.06.1/bin/ocaml"
/nix/store/i8p47jwflgj1xzfid19yaalfkrqx4il3-ocaml4.06.1-reason-3.3.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7/bin/ocamlmerlin-reason
shrinking /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/rtop/rtop.cmxs
shrinking /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/reason.cmxs
shrinking /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7/lib/ocaml/4.06.1/site-lib/reason/easy_format/reason.easy_format.cmxs
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7/lib  /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7/bin
patching script interpreter paths in /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7
/nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/69z8hbbba1w59nbcylfglsh4lvb9fnc5-ocaml-4.06.1/bin/ocaml"
checking for references to /build in /nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7...
/nix/store/8lr2arg8sr4s8f96nabcndi1cs0bx4kn-ocaml4.06.1-reason-3.3.7

@c0bw3b c0bw3b merged commit 8ef70a0 into NixOS:master Oct 28, 2018
@vbgl vbgl deleted the reason-3.3.7 branch October 28, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @c0bw3b