Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/installation-device: set GC initial heap size to 1MB #49326

Merged
merged 1 commit into from Oct 30, 2018
Merged

nixos/installation-device: set GC initial heap size to 1MB #49326

merged 1 commit into from Oct 30, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 28, 2018

Motivation for this change

100000 (100kB) is too aggressive (too low) and gets ignored by the GC after raising warnings.
See issue #43339

I'll make a second PR for backporting to 18.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
installation-device: set GC initial heap size to 1MB
fc47659 
100000 (100kB) is too aggressive (too low) and gets ignored by the GC
See issue NixOS#43339
@c0bw3b c0bw3b mentioned this pull request Oct 28, 2018
Merged
9 tasks
@markuskowa
Copy link
Member

markuskowa commented Oct 28, 2018 •
edited

I can run some of the installer tests again (locally). That seems to solve the problem.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 30, 2018

Maybe I should cc @edolstra since you are the author of the previous setting

@edolstra edolstra merged commit be6e4b8 into NixOS:master Oct 30, 2018
@c0bw3b c0bw3b deleted the nixos/installation-device branch November 6, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@c0bw3b @markuskowa @matthewbauer @edolstra @GrahamcOfBorg