Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-deploy: 1.0.2 -> 1.0.3 #49323

Closed
wants to merge 1 commit into from
Closed

nix-deploy: 1.0.2 -> 1.0.3 #49323

wants to merge 1 commit into from

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Oct 28, 2018

Motivation for this change

Fixes awakesecurity/nix-deploy#20

Things done

nix-build -A nix-deploy .

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member

Please don't edit hackage-packages.nix manually. That file is periodically generated and will contain nix-deploy-1.0.3 on the next iteration.

@basvandijk basvandijk closed this Oct 28, 2018
@clefru
Copy link
Contributor Author

clefru commented Nov 12, 2018

How does this get into release-18.09? Looks like there is nothing that updates release-18.09 automatically.

@peti
Copy link
Member

peti commented Nov 12, 2018 •
edited

Yes, the release branch gets no updates except for the purpose of fixing security issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clefru @basvandijk @peti @GrahamcOfBorg