Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages: add fkill-cli #49308

Closed
wants to merge 3 commits into from
Closed

nodePackages: add fkill-cli #49308

wants to merge 3 commits into from

Conversation

aaronjanse
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Nov 8, 2018

please regenerate the nodejs package set using the generate.sh script in the same directory. Otherwise the package won't be available in the package set.

@Mic92
Copy link
Member

Mic92 commented Nov 9, 2018

I can add it in #50003
as well.

@aaronjanse
Copy link
Member Author

I could not get nix-build -A nodePackages.fkill to run; it couldn't find the package.

I was able to do it last time, however, but I used a flag that I have since forgotten.

I assume the problem is with my setup (and nix-build knowing to use the current directory for nixpkgs), not with the package.

@Ma27
Copy link
Member

Ma27 commented Nov 10, 2018

I could not get nix-build -A nodePackages.fkill to run; it couldn't find the package.

As far as I can tell you only added a part of the changed node-packages.nix, right? Because at the bottom of the file you have buildNodePackage statements that actually define the package build and they appear to be missing.

I recommend to simply commit the full change (although this makes the patch fairly big, I know), but then you can be sure that you have a working package set of NodeJS packages. Otherwise it can't be guaranteed that all definitions are compatible with each other.

@aaronjanse
Copy link
Member Author

That must be the case, thank you. I hoped to save time, but should followed the instructions directly.

The commit I just made includes the full changes of generate.sh.

$ nix-build . -A nodePackages.fkill-cli
/nix/store/9k22xc23pf0r0jb9d1v3mgm2azq00fmb-node-fkill-cli-5.2.0
$ ls /nix/store/9k22xc23pf0r0jb9d1v3mgm2azq00fmb-node-fkill-cli-5.2.0/bin
fkill
$ /nix/store/9k22xc23pf0r0jb9d1v3mgm2azq00fmb-node-fkill-cli-5.2.0/bin/fkill
[fkill runs, working as intended as far as I can tell]

Thank you for the patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants