Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.distribute: init at 0.7.3 #49340

Closed
wants to merge 1 commit into from
Closed

pythonPackages.distribute: init at 0.7.3 #49340

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 28, 2018

Motivation for this change

Somewhat hacky? Uses build-python-package-common.nix attrs.
Only built successfully on pythonPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested a review from FRidh as a code owner October 28, 2018 13:16
@eadwu eadwu mentioned this pull request Oct 28, 2018
Closed
9 tasks
@FRidh
Copy link
Member

FRidh commented Oct 28, 2018

Why would we want to have this old stuff in Nixpkgs? I'm closing this.

@FRidh FRidh closed this Oct 28, 2018
@eadwu eadwu mentioned this pull request Oct 29, 2018
Merged
9 tasks
@eadwu eadwu deleted the init/pythonPackages.distribute branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @FRidh @GrahamcOfBorg